tyler/proxmox-backup
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

style: BufferedReader -> BufferedRead

Browse Source 
Single-method traits usually use the same name as their
method and aren't usually the 'noun' (which is usually an
implementation of them instead).

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
This commit is contained in:
Wolfgang Bumiller
2019-02-28 09:17:04 +01:00
parent 8f57971714
commit fded74d0c7
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backup/dynamic_index.rs
View File

@ -235,7 +235,7 @@ impl BufferedDynamicReader {
} }
} }
impl crate::tools::BufferedReader for BufferedDynamicReader { impl crate::tools::BufferedRead for BufferedDynamicReader {
fn buffered_read(&mut self, offset: u64) -> Result<&[u8], Error> { fn buffered_read(&mut self, offset: u64) -> Result<&[u8], Error> {
@ -279,7 +279,7 @@ impl std::io::Read for BufferedDynamicReader {
fn read(&mut self, buf: &mut [u8]) -> Result<usize, std::io::Error> { fn read(&mut self, buf: &mut [u8]) -> Result<usize, std::io::Error> {
use std::io::{Error, ErrorKind}; use std::io::{Error, ErrorKind};
use crate::tools::BufferedReader; use crate::tools::BufferedRead;
let data = match self.buffered_read(self.read_offset) { let data = match self.buffered_read(self.read_offset) {
Ok(v) => v, Ok(v) => v,

4
src/tools.rs
View File

@ -50,10 +50,10 @@ macro_rules! try_block {
} }
/// The `BufferedReader` trait provides a single function /// The `BufferedRead` trait provides a single function
/// `buffered_read`. It returns a reference to an internal buffer. The /// `buffered_read`. It returns a reference to an internal buffer. The
/// purpose of this traid is to avoid unnecessary data copies. /// purpose of this traid is to avoid unnecessary data copies.
pub trait BufferedReader { pub trait BufferedRead {
/// This functions tries to fill the internal buffers, then /// This functions tries to fill the internal buffers, then
/// returns a reference to the available data. It returns an empty /// returns a reference to the available data. It returns an empty
/// buffer if `offset` points to the end of the file. /// buffer if `offset` points to the end of the file.