From fded74d0c76979d45e18d5d88249e283beabb83c Mon Sep 17 00:00:00 2001 From: Wolfgang Bumiller Date: Thu, 28 Feb 2019 09:17:04 +0100 Subject: [PATCH] style: BufferedReader -> BufferedRead Single-method traits usually use the same name as their method and aren't usually the 'noun' (which is usually an implementation of them instead). Signed-off-by: Wolfgang Bumiller --- src/backup/dynamic_index.rs | 4 ++-- src/tools.rs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backup/dynamic_index.rs b/src/backup/dynamic_index.rs index 668a1b62..a5ac821e 100644 --- a/src/backup/dynamic_index.rs +++ b/src/backup/dynamic_index.rs @@ -235,7 +235,7 @@ impl BufferedDynamicReader { } } -impl crate::tools::BufferedReader for BufferedDynamicReader { +impl crate::tools::BufferedRead for BufferedDynamicReader { fn buffered_read(&mut self, offset: u64) -> Result<&[u8], Error> { @@ -279,7 +279,7 @@ impl std::io::Read for BufferedDynamicReader { fn read(&mut self, buf: &mut [u8]) -> Result { use std::io::{Error, ErrorKind}; - use crate::tools::BufferedReader; + use crate::tools::BufferedRead; let data = match self.buffered_read(self.read_offset) { Ok(v) => v, diff --git a/src/tools.rs b/src/tools.rs index a44360a2..289b7aec 100644 --- a/src/tools.rs +++ b/src/tools.rs @@ -50,10 +50,10 @@ macro_rules! try_block { } -/// The `BufferedReader` trait provides a single function +/// The `BufferedRead` trait provides a single function /// `buffered_read`. It returns a reference to an internal buffer. The /// purpose of this traid is to avoid unnecessary data copies. -pub trait BufferedReader { +pub trait BufferedRead { /// This functions tries to fill the internal buffers, then /// returns a reference to the available data. It returns an empty /// buffer if `offset` points to the end of the file.