tyler
/
proxmox-backup
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

log rotate: do NOT overwrite file with possible writers 

this is not the job of logrotate, and the real 20+ years battle
tested log rotate binary does not do so either as it's actually
pretty dangerous.

If we "replace" the file we break any logger which already opened a
new one here, e.g., a dameon starting up, and thus that writer would
log to nirvana.

It's the job of a logger to create a file if not existing, it makes
no sense to do it here.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2020-10-20 10:05:51 +02:00
parent 0698f78df5
commit e6ca9c3235
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/tools/logrotate.rs
View File

@ -6,7 +6,7 @@ use std::io::Read;
use anyhow::{bail, Error}; use anyhow::{bail, Error};
use nix::unistd; use nix::unistd;
use proxmox::tools::fs::{CreateOptions, make_tmp_file, replace_file}; use proxmox::tools::fs::{CreateOptions, make_tmp_file};
/// Used for rotating log files and iterating over them /// Used for rotating log files and iterating over them
pub struct LogRotate { pub struct LogRotate {
@ -108,8 +108,6 @@ impl LogRotate {
rename(&filenames[0], &filenames[1])?; rename(&filenames[0], &filenames[1])?;
} }
// create empty original file
replace_file(&filenames[0], b"", options)?;
if let Some(max_files) = max_files { if let Some(max_files) = max_files {
// delete all files > max_files // delete all files > max_files