From e6ca9c3235dc22f21b4633db8f50c86bfa9e6540 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Tue, 20 Oct 2020 10:05:51 +0200 Subject: [PATCH] log rotate: do NOT overwrite file with possible writers this is not the job of logrotate, and the real 20+ years battle tested log rotate binary does not do so either as it's actually pretty dangerous. If we "replace" the file we break any logger which already opened a new one here, e.g., a dameon starting up, and thus that writer would log to nirvana. It's the job of a logger to create a file if not existing, it makes no sense to do it here. Signed-off-by: Thomas Lamprecht --- src/tools/logrotate.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/tools/logrotate.rs b/src/tools/logrotate.rs index ce311fbe..f7d1a693 100644 --- a/src/tools/logrotate.rs +++ b/src/tools/logrotate.rs @@ -6,7 +6,7 @@ use std::io::Read; use anyhow::{bail, Error}; use nix::unistd; -use proxmox::tools::fs::{CreateOptions, make_tmp_file, replace_file}; +use proxmox::tools::fs::{CreateOptions, make_tmp_file}; /// Used for rotating log files and iterating over them pub struct LogRotate { @@ -108,8 +108,6 @@ impl LogRotate { rename(&filenames[0], &filenames[1])?; } - // create empty original file - replace_file(&filenames[0], b"", options)?; if let Some(max_files) = max_files { // delete all files > max_files