tyler/proxmox-backup
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

chunk_store: insert_chunk: write chunk again if it is empty on disk

Browse Source 
and issue a warning. We can do this, because we know an empty chunk
cannot be valid, and we (assumedly) have a valid chunk in memory.

Having empty chunks on disk is currently possible when PBS crashes,
but the rename of the chunk was flushed to disk, when the actual data
was not.

If it's not empty but there is a size mismatch, return an error.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2022-05-09 16:09:06 +02:00 committed by Thomas Lamprecht
parent 8915c1e74a
commit dd612daab0
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
pbs-datastore/src/chunk_store.rs
View File

@ -458,17 +458,26 @@ impl ChunkStore {
let lock = self.mutex.lock();
let raw_data = chunk.raw_data();
let encoded_size = raw_data.len() as u64;
if let Ok(metadata) = std::fs::metadata(&chunk_path) {
if metadata.is_file() {
self.touch_chunk(digest)?;
return Ok((true, metadata.len()));
} else {
if !metadata.is_file() {
bail!(
"Got unexpected file type on store '{}' for chunk {}",
self.name,
digest_str
);
}
let old_size = metadata.len();
if encoded_size == old_size {
self.touch_chunk(digest)?;
return Ok((true, old_size));
} else if old_size == 0 {
log::warn!("found empty chunk '{digest_str}' on disk, overwriting");
} else {
bail!("found chunk size mismatch for '{digest_str}': old {old_size} - new {encoded_size}");
}
}
let mut tmp_path = chunk_path.clone();
@ -483,9 +492,6 @@ impl ChunkStore {
)
})?;
let raw_data = chunk.raw_data();
let encoded_size = raw_data.len() as u64;
file.write_all(raw_data).map_err(|err| {
format_err!(
"writing temporary chunk on store '{}' failed for {} - {}",