tyler/proxmox-backup
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix #3058: ui: improve remote edit UX by clarifying ID vs host

Browse Source 
also fixup missing emptyText for fingerprint (adapted from PVE's PBS
storage addition) and code-style in surrounding areas a bit

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2022-01-12 09:38:20 +01:00
parent 64c075b6c2
commit 2e02a859cf
4 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
www/config/RemoteView.js
View File

@ -116,7 +116,7 @@ Ext.define('PBS.config.RemoteView', {
columns: [
{
header: gettext('Remote'),
header: gettext('Remote ID'),
width: 200,
sortable: true,
renderer: Ext.String.htmlEncode,

2
www/config/SyncView.js
View File

@ -196,7 +196,7 @@ Ext.define('PBS.config.SyncJobView', {
sortable: true,
},
{
header: gettext('Remote'),
header: gettext('Remote ID'),
dataIndex: 'remote',
width: 120,
sortable: true,

2
www/form/RemoteSelector.js
View File

@ -16,7 +16,7 @@ Ext.define('PBS.form.RemoteSelector', {
listConfig: {
columns: [
{
header: gettext('Remote'),
header: gettext('Remote ID'),
sortable: true,
dataIndex: 'name',
renderer: Ext.String.htmlEncode,

14
www/window/RemoteEdit.js
View File

@ -32,7 +32,7 @@ Ext.define('PBS.window.RemoteEdit', {
{
xtype: 'pmxDisplayEditField',
name: 'name',
fieldLabel: gettext('Remote'),
fieldLabel: gettext('Remote ID'),
renderer: Ext.htmlEncode,
allowBlank: false,
minLength: 4,
@ -47,6 +47,7 @@ Ext.define('PBS.window.RemoteEdit', {
submitValue: false,
vtype: 'HostPort',
fieldLabel: gettext('Host'),
emptyText: gettext('FQDN or IP-address'),
listeners: {
change: function(field, newvalue) {
let host = newvalue;
@ -74,31 +75,31 @@ Ext.define('PBS.window.RemoteEdit', {
},
{
xtype: 'proxmoxtextfield',
hidden: true,
name: 'host',
hidden: true,
},
{
xtype: 'proxmoxtextfield',
name: 'port',
hidden: true,
cbind: {
deleteEmpty: '{!isCreate}',
},
name: 'port',
},
],
column2: [
{
xtype: 'proxmoxtextfield',
allowBlank: false,
name: 'auth-id',
fieldLabel: gettext('Auth ID'),
allowBlank: false,
},
{
xtype: 'textfield',
name: 'password',
inputType: 'password',
fieldLabel: gettext('Password'),
name: 'password',
cbind: {
emptyText: '{passwordEmptyText}',
allowBlank: '{!isCreate}',
@ -110,10 +111,11 @@ Ext.define('PBS.window.RemoteEdit', {
{
xtype: 'proxmoxtextfield',
name: 'fingerprint',
fieldLabel: gettext('Fingerprint'),
emptyText: gettext("Server certificate's SHA-256 fingerprint, required for self-signed certificates"),
cbind: {
deleteEmpty: '{!isCreate}',
},
fieldLabel: gettext('Fingerprint'),
},
{
xtype: 'proxmoxtextfield',