proxmox-backup/src/tools/disks.rs
2020-06-07 10:30:34 +02:00

883 lines
26 KiB
Rust

//! Disk query/management utilities for.
use std::collections::{HashMap, HashSet};
use std::ffi::{OsStr, OsString};
use std::io;
use std::os::unix::ffi::{OsStrExt, OsStringExt};
use std::path::{Path, PathBuf};
use std::sync::Arc;
use bitflags::bitflags;
use anyhow::{bail, format_err, Error};
use libc::dev_t;
use once_cell::sync::OnceCell;
use ::serde::{Deserialize, Serialize};
use proxmox::sys::error::io_err_other;
use proxmox::sys::linux::procfs::{MountInfo, mountinfo::Device};
use proxmox::{io_bail, io_format_err};
use proxmox::api::api;
use crate::api2::types::BLOCKDEVICE_NAME_REGEX;
mod zfs;
pub use zfs::*;
mod lvm;
pub use lvm::*;
mod smart;
pub use smart::*;
lazy_static::lazy_static!{
static ref ISCSI_PATH_REGEX: regex::Regex =
regex::Regex::new(r"host[^/]*/session[^/]*").unwrap();
}
bitflags! {
/// Ways a device is being used.
pub struct DiskUse: u32 {
/// Currently mounted.
const MOUNTED = 0x0000_0001;
/// Currently used as member of a device-mapper device.
const DEVICE_MAPPER = 0x0000_0002;
/// Contains partitions.
const PARTITIONS = 0x0001_0000;
/// The disk has a partition type which belongs to an LVM PV.
const LVM = 0x0002_0000;
/// The disk has a partition type which belongs to a zpool.
const ZFS = 0x0004_0000;
/// The disk is used by ceph.
const CEPH = 0x0008_0000;
}
}
/// Disk management context.
///
/// This provides access to disk information with some caching for faster querying of multiple
/// devices.
pub struct DiskManage {
mount_info: OnceCell<MountInfo>,
mounted_devices: OnceCell<HashSet<dev_t>>,
}
impl DiskManage {
/// Create a new disk management context.
pub fn new() -> Arc<Self> {
Arc::new(Self {
mount_info: OnceCell::new(),
mounted_devices: OnceCell::new(),
})
}
/// Get the current mount info. This simply caches the result of `MountInfo::read` from the
/// `proxmox::sys` module.
pub fn mount_info(&self) -> Result<&MountInfo, Error> {
self.mount_info.get_or_try_init(MountInfo::read)
}
/// Get a `Disk` from a device node (eg. `/dev/sda`).
pub fn disk_by_node<P: AsRef<Path>>(self: Arc<Self>, devnode: P) -> io::Result<Disk> {
use std::os::unix::fs::MetadataExt;
let devnode = devnode.as_ref();
let meta = std::fs::metadata(devnode)?;
if (meta.mode() & libc::S_IFBLK) == libc::S_IFBLK {
self.disk_by_dev_num(meta.rdev())
} else {
io_bail!("not a block device: {:?}", devnode);
}
}
/// Get a `Disk` for a specific device number.
pub fn disk_by_dev_num(self: Arc<Self>, devnum: dev_t) -> io::Result<Disk> {
self.disk_by_sys_path(format!(
"/sys/dev/block/{}:{}",
unsafe { libc::major(devnum) },
unsafe { libc::minor(devnum) },
))
}
/// Get a `Disk` for a path in `/sys`.
pub fn disk_by_sys_path<P: AsRef<Path>>(self: Arc<Self>, path: P) -> io::Result<Disk> {
let device = udev::Device::from_syspath(path.as_ref())?;
Ok(Disk {
manager: self,
device,
info: Default::default(),
})
}
/// Get a `Disk` for a name in `/sys/block/<name>`.
pub fn disk_by_name(self: Arc<Self>, name: &str) -> io::Result<Disk> {
let syspath = format!("/sys/block/{}", name);
self.disk_by_sys_path(&syspath)
}
/// Gather information about mounted disks:
fn mounted_devices(&self) -> Result<&HashSet<dev_t>, Error> {
use std::os::unix::fs::MetadataExt;
self.mounted_devices
.get_or_try_init(|| -> Result<_, Error> {
let mut mounted = HashSet::new();
for (_id, mp) in self.mount_info()? {
let source = match mp.mount_source.as_ref().map(OsString::as_os_str) {
Some(s) => s,
None => continue,
};
let path = Path::new(source);
if !path.is_absolute() {
continue;
}
let meta = match std::fs::metadata(path) {
Ok(meta) => meta,
Err(ref err) if err.kind() == io::ErrorKind::NotFound => continue,
Err(other) => return Err(Error::from(other)),
};
if (meta.mode() & libc::S_IFBLK) != libc::S_IFBLK {
// not a block device
continue;
}
mounted.insert(meta.rdev());
}
Ok(mounted)
})
}
/// Information about file system type and unsed device for a path
///
/// Returns tuple (fs_type, device, mount_source)
pub fn find_mounted_device(
&self,
path: &std::path::Path,
) -> Result<Option<(String, Device, Option<OsString>)>, Error> {
let stat = nix::sys::stat::stat(path)?;
let device = Device::from_dev_t(stat.st_dev);
let root_path = std::path::Path::new("/");
for (_id, entry) in self.mount_info()? {
if entry.root == root_path && entry.device == device {
return Ok(Some((entry.fs_type.clone(), entry.device, entry.mount_source.clone())));
}
}
Ok(None)
}
/// Check whether a specific device node is mounted.
///
/// Note that this tries to `stat` the sources of all mount points without caching the result
/// of doing so, so this is always somewhat expensive.
pub fn is_devnum_mounted(&self, dev: dev_t) -> Result<bool, Error> {
self.mounted_devices().map(|mounted| mounted.contains(&dev))
}
}
/// Queries (and caches) various information about a specific disk.
///
/// This belongs to a `Disks` and provides information for a single disk.
pub struct Disk {
manager: Arc<DiskManage>,
device: udev::Device,
info: DiskInfo,
}
/// Helper struct (so we can initialize this with Default)
///
/// We probably want this to be serializable to the same hash type we use in perl currently.
#[derive(Default)]
struct DiskInfo {
size: OnceCell<u64>,
vendor: OnceCell<Option<OsString>>,
model: OnceCell<Option<OsString>>,
rotational: OnceCell<Option<bool>>,
// for perl: #[serde(rename = "devpath")]
ata_rotation_rate_rpm: OnceCell<Option<u64>>,
// for perl: #[serde(rename = "devpath")]
device_path: OnceCell<Option<PathBuf>>,
wwn: OnceCell<Option<OsString>>,
serial: OnceCell<Option<OsString>>,
// for perl: #[serde(skip_serializing)]
partition_table_type: OnceCell<Option<OsString>>,
gpt: OnceCell<bool>,
// ???
bus: OnceCell<Option<OsString>>,
// ???
fs_type: OnceCell<Option<OsString>>,
// ???
has_holders: OnceCell<bool>,
// ???
is_mounted: OnceCell<bool>,
}
impl Disk {
/// Try to get the device number for this disk.
///
/// (In udev this can fail...)
pub fn devnum(&self) -> Result<dev_t, Error> {
// not sure when this can fail...
self.device
.devnum()
.ok_or_else(|| format_err!("failed to get device number"))
}
/// Get the sys-name of this device. (The final component in the `/sys` path).
pub fn sysname(&self) -> &OsStr {
self.device.sysname()
}
/// Get the this disk's `/sys` path.
pub fn syspath(&self) -> &Path {
self.device.syspath()
}
/// Get the device node in `/dev`, if any.
pub fn device_path(&self) -> Option<&Path> {
//self.device.devnode()
self.info
.device_path
.get_or_init(|| self.device.devnode().map(Path::to_owned))
.as_ref()
.map(PathBuf::as_path)
}
/// Get the parent device.
pub fn parent(&self) -> Option<Self> {
self.device.parent().map(|parent| Self {
manager: self.manager.clone(),
device: parent,
info: Default::default(),
})
}
/// Read from a file in this device's sys path.
///
/// Note: path must be a relative path!
pub fn read_sys(&self, path: &Path) -> io::Result<Option<Vec<u8>>> {
assert!(path.is_relative());
std::fs::read(self.syspath().join(path))
.map(Some)
.or_else(|err| {
if err.kind() == io::ErrorKind::NotFound {
Ok(None)
} else {
Err(err)
}
})
}
/// Convenience wrapper for reading a `/sys` file which contains just a simple `OsString`.
fn read_sys_os_str<P: AsRef<Path>>(&self, path: P) -> io::Result<Option<OsString>> {
Ok(self.read_sys(path.as_ref())?.map(|mut v| {
if Some(&b'\n') == v.last() {
v.pop();
}
OsString::from_vec(v)
}))
}
/// Convenience wrapper for reading a `/sys` file which contains just a simple utf-8 string.
fn read_sys_str<P: AsRef<Path>>(&self, path: P) -> io::Result<Option<String>> {
Ok(match self.read_sys(path.as_ref())? {
Some(data) => Some(String::from_utf8(data).map_err(io_err_other)?),
None => None,
})
}
/// Convenience wrapper for unsigned integer `/sys` values up to 64 bit.
fn read_sys_u64<P: AsRef<Path>>(&self, path: P) -> io::Result<Option<u64>> {
Ok(match self.read_sys_str(path)? {
Some(data) => Some(data.trim().parse().map_err(io_err_other)?),
None => None,
})
}
/// Get the disk's size in bytes.
pub fn size(&self) -> io::Result<u64> {
Ok(*self.info.size.get_or_try_init(|| {
self.read_sys_u64("size")?.map(|s| s*512).ok_or_else(|| {
io_format_err!(
"failed to get disk size from {:?}",
self.syspath().join("size"),
)
})
})?)
}
/// Get the device vendor (`/sys/.../device/vendor`) entry if available.
pub fn vendor(&self) -> io::Result<Option<&OsStr>> {
Ok(self
.info
.vendor
.get_or_try_init(|| self.read_sys_os_str("device/vendor"))?
.as_ref()
.map(OsString::as_os_str))
}
/// Get the device model (`/sys/.../device/model`) entry if available.
pub fn model(&self) -> Option<&OsStr> {
self.info
.model
.get_or_init(|| self.device.property_value("ID_MODEL").map(OsStr::to_owned))
.as_ref()
.map(OsString::as_os_str)
}
/// Check whether this is a rotational disk.
///
/// Returns `None` if there's no `queue/rotational` file, in which case no information is
/// known. `Some(false)` if `queue/rotational` is zero, `Some(true)` if it has a non-zero
/// value.
pub fn rotational(&self) -> io::Result<Option<bool>> {
Ok(*self
.info
.rotational
.get_or_try_init(|| -> io::Result<Option<bool>> {
Ok(self.read_sys_u64("queue/rotational")?.map(|n| n != 0))
})?)
}
/// Get the WWN if available.
pub fn wwn(&self) -> Option<&OsStr> {
self.info
.wwn
.get_or_init(|| self.device.property_value("ID_WWN").map(|v| v.to_owned()))
.as_ref()
.map(OsString::as_os_str)
}
/// Get the device serial if available.
pub fn serial(&self) -> Option<&OsStr> {
self.info
.serial
.get_or_init(|| {
self.device
.property_value("ID_SERIAL_SHORT")
.map(|v| v.to_owned())
})
.as_ref()
.map(OsString::as_os_str)
}
/// Get the ATA rotation rate value from udev. This is not necessarily the same as sysfs'
/// `rotational` value.
pub fn ata_rotation_rate_rpm(&self) -> Option<u64> {
*self.info.ata_rotation_rate_rpm.get_or_init(|| {
std::str::from_utf8(
self.device
.property_value("ID_ATA_ROTATION_RATE_RPM")?
.as_bytes(),
)
.ok()?
.parse()
.ok()
})
}
/// Get the partition table type, if any.
pub fn partition_table_type(&self) -> Option<&OsStr> {
self.info
.partition_table_type
.get_or_init(|| {
self.device
.property_value("ID_PART_TABLE_TYPE")
.map(|v| v.to_owned())
})
.as_ref()
.map(OsString::as_os_str)
}
/// Check if this contains a GPT partition table.
pub fn has_gpt(&self) -> bool {
*self.info.gpt.get_or_init(|| {
self.partition_table_type()
.map(|s| s == "gpt")
.unwrap_or(false)
})
}
/// Get the bus type used for this disk.
pub fn bus(&self) -> Option<&OsStr> {
self.info
.bus
.get_or_init(|| self.device.property_value("ID_BUS").map(|v| v.to_owned()))
.as_ref()
.map(OsString::as_os_str)
}
/// Attempt to guess the disk type.
pub fn guess_disk_type(&self) -> io::Result<DiskType> {
Ok(match self.rotational()? {
Some(false) => DiskType::Ssd,
Some(true) => DiskType::Hdd,
None => match self.ata_rotation_rate_rpm() {
Some(_) => DiskType::Hdd,
None => match self.bus() {
Some(bus) if bus == "usb" => DiskType::Usb,
_ => DiskType::Unknown,
},
},
})
}
/// Get the file system type found on the disk, if any.
///
/// Note that `None` may also just mean "unknown".
pub fn fs_type(&self) -> Option<&OsStr> {
self.info
.fs_type
.get_or_init(|| {
self.device
.property_value("ID_FS_TYPE")
.map(|v| v.to_owned())
})
.as_ref()
.map(OsString::as_os_str)
}
/// Check if there are any "holders" in `/sys`. This usually means the device is in use by
/// another kernel driver like the device mapper.
pub fn has_holders(&self) -> io::Result<bool> {
Ok(*self
.info
.has_holders
.get_or_try_init(|| -> io::Result<bool> {
let mut subdir = self.syspath().to_owned();
subdir.push("holders");
for entry in std::fs::read_dir(subdir)? {
match entry?.file_name().as_bytes() {
b"." | b".." => (),
_ => return Ok(true),
}
}
Ok(false)
})?)
}
/// Check if this disk is mounted.
pub fn is_mounted(&self) -> Result<bool, Error> {
Ok(*self
.info
.is_mounted
.get_or_try_init(|| self.manager.is_devnum_mounted(self.devnum()?))?)
}
/// Read block device stats
///
/// see https://www.kernel.org/doc/Documentation/block/stat.txt
pub fn read_stat(&self) -> std::io::Result<Option<BlockDevStat>> {
if let Some(stat) = self.read_sys(Path::new("stat"))? {
let stat = unsafe { std::str::from_utf8_unchecked(&stat) };
let stat: Vec<u64> = stat.split_ascii_whitespace().map(|s| {
u64::from_str_radix(s, 10).unwrap_or(0)
}).collect();
if stat.len() < 15 { return Ok(None); }
return Ok(Some(BlockDevStat {
read_ios: stat[0],
read_sectors: stat[2],
write_ios: stat[4] + stat[11], // write + discard
write_sectors: stat[6] + stat[13], // write + discard
io_ticks: stat[10],
}));
}
Ok(None)
}
}
/// Returns disk usage information (total, used, avail)
pub fn disk_usage(path: &std::path::Path) -> Result<(u64, u64, u64), Error> {
let mut stat: libc::statfs64 = unsafe { std::mem::zeroed() };
use nix::NixPath;
let res = path.with_nix_path(|cstr| unsafe { libc::statfs64(cstr.as_ptr(), &mut stat) })?;
nix::errno::Errno::result(res)?;
let bsize = stat.f_bsize as u64;
Ok((stat.f_blocks*bsize, (stat.f_blocks-stat.f_bfree)*bsize, stat.f_bavail*bsize))
}
#[api()]
#[derive(Debug, Serialize, Deserialize)]
#[serde(rename_all="lowercase")]
/// This is just a rough estimate for a "type" of disk.
pub enum DiskType {
/// We know nothing.
Unknown,
/// May also be a USB-HDD.
Hdd,
/// May also be a USB-SSD.
Ssd,
/// Some kind of USB disk, but we don't know more than that.
Usb,
}
#[derive(Debug)]
/// Represents the contents of the /sys/block/<dev>/stat file.
pub struct BlockDevStat {
pub read_ios: u64,
pub read_sectors: u64,
pub write_ios: u64,
pub write_sectors: u64,
pub io_ticks: u64, // milliseconds
}
/// Use lsblk to read partition type uuids.
pub fn get_partition_type_info() -> Result<HashMap<String, Vec<String>>, Error> {
const LSBLK_BIN_PATH: &str = "/usr/bin/lsblk";
let mut command = std::process::Command::new(LSBLK_BIN_PATH);
command.args(&["--json", "-o", "path,parttype"]);
let output = command.output()
.map_err(|err| format_err!("failed to execute '{}' - {}", LSBLK_BIN_PATH, err))?;
let output = crate::tools::command_output(output, None)
.map_err(|err| format_err!("lsblk command failed: {}", err))?;
let mut res: HashMap<String, Vec<String>> = HashMap::new();
let output: serde_json::Value = output.parse()?;
match output["blockdevices"].as_array() {
Some(list) => {
for info in list {
let path = match info["path"].as_str() {
Some(p) => p,
None => continue,
};
let partition_type = match info["parttype"].as_str() {
Some(t) => t.to_owned(),
None => continue,
};
let devices = res.entry(partition_type).or_insert(Vec::new());
devices.push(path.to_string());
}
}
None => {
}
}
Ok(res)
}
#[api()]
#[derive(Debug, Serialize, Deserialize, PartialEq)]
#[serde(rename_all="lowercase")]
pub enum DiskUsageType {
/// Disk is not used (as far we can tell)
Unused,
/// Disk is mounted
Mounted,
/// Disk is used by LVM
LVM,
/// Disk is used by ZFS
ZFS,
/// Disk is used by device-mapper
DeviceMapper,
/// Disk has partitions
Partitions,
}
#[api(
properties: {
used: {
type: DiskUsageType,
},
"disk-type": {
type: DiskType,
},
status: {
type: SmartStatus,
}
}
)]
#[derive(Debug, Serialize, Deserialize)]
#[serde(rename_all="kebab-case")]
/// Information about how a Disk is used
pub struct DiskUsageInfo {
/// Disk name (/sys/block/<name>)
pub name: String,
pub used: DiskUsageType,
pub disk_type: DiskType,
pub status: SmartStatus,
/// Disk wearout
pub wearout: Option<f64>,
/// Vendor
pub vendor: Option<String>,
/// Model
pub model: Option<String>,
/// WWN
pub wwn: Option<String>,
/// Disk size
pub size: u64,
/// Serisal number
pub serial: Option<String>,
/// Linux device path (/dev/xxx)
pub devpath: Option<String>,
/// Set if disk contains a GPT partition table
pub gpt: bool,
/// RPM
pub rpm: Option<u64>,
}
fn scan_partitions(
disk_manager: Arc<DiskManage>,
lvm_devices: &HashSet<String>,
zfs_devices: &HashSet<String>,
device: &str,
) -> Result<DiskUsageType, Error> {
let mut sys_path = std::path::PathBuf::from("/sys/block");
sys_path.push(device);
let mut used = DiskUsageType::Unused;
let mut found_lvm = false;
let mut found_zfs = false;
let mut found_mountpoints = false;
let mut found_dm = false;
let mut found_partitions = false;
for item in crate::tools::fs::read_subdir(libc::AT_FDCWD, &sys_path)? {
let item = item?;
let name = match item.file_name().to_str() {
Ok(name) => name,
Err(_) => continue, // skip non utf8 entries
};
if !name.starts_with(device) { continue; }
found_partitions = true;
let mut part_path = sys_path.clone();
part_path.push(name);
let data = disk_manager.clone().disk_by_sys_path(&part_path)?;
if lvm_devices.contains(name) {
found_lvm = true;
}
if data.is_mounted()? {
found_mountpoints = true;
}
if data.has_holders()? {
found_dm = true;
}
if zfs_devices.contains(name) {
found_zfs = true;
}
}
if found_mountpoints {
used = DiskUsageType::Mounted;
} else if found_lvm {
used = DiskUsageType::LVM;
} else if found_zfs {
used = DiskUsageType::ZFS;
} else if found_dm {
used = DiskUsageType::DeviceMapper;
} else if found_partitions {
used = DiskUsageType::Partitions;
}
Ok(used)
}
/// Get disk usage information for a single disk
pub fn get_disk_usage_info(
disk: &str,
no_smart: bool,
) -> Result<DiskUsageInfo, Error> {
let mut filter = Vec::new();
filter.push(disk.to_string());
let mut map = get_disks(Some(filter), no_smart)?;
if let Some(info) = map.remove(disk) {
return Ok(info);
} else {
bail!("failed to get disk usage info - internal error"); // should not happen
}
}
/// Get disk usage information for multiple disks
pub fn get_disks(
// filter - list of device names (without leading /dev)
disks: Option<Vec<String>>,
// do no include data from smartctl
no_smart: bool,
) -> Result<HashMap<String, DiskUsageInfo>, Error> {
let disk_manager = DiskManage::new();
let partition_type_map = get_partition_type_info()?;
let zfs_devices = zfs_devices(&partition_type_map, None)?;
let lvm_devices = get_lvm_devices(&partition_type_map)?;
// fixme: ceph journals/volumes
let mut result = HashMap::new();
for item in crate::tools::fs::scan_subdir(libc::AT_FDCWD, "/sys/block", &BLOCKDEVICE_NAME_REGEX)? {
let item = item?;
let name = item.file_name().to_str().unwrap().to_string();
if let Some(ref disks) = disks {
if !disks.contains(&name) { continue; }
}
let sys_path = format!("/sys/block/{}", name);
if let Ok(target) = std::fs::read_link(&sys_path) {
if let Some(target) = target.to_str() {
if ISCSI_PATH_REGEX.is_match(target) { continue; } // skip iSCSI devices
}
}
let disk = disk_manager.clone().disk_by_sys_path(&sys_path)?;
let size = match disk.size() {
Ok(size) => size,
Err(_) => continue, // skip devices with unreadable size
};
let disk_type = match disk.guess_disk_type() {
Ok(disk_type) => disk_type,
Err(_) => continue, // skip devices with undetectable type
};
let mut usage = DiskUsageType::Unused;
if lvm_devices.contains(&name) {
usage = DiskUsageType::LVM;
}
match disk.is_mounted() {
Ok(true) => usage = DiskUsageType::Mounted,
Ok(false) => {},
Err(_) => continue, // skip devices with undetectable mount status
}
if zfs_devices.contains(&name) {
usage = DiskUsageType::ZFS;
}
let vendor = disk.vendor().unwrap_or(None).
map(|s| s.to_string_lossy().trim().to_string());
let model = disk.model().map(|s| s.to_string_lossy().into_owned());
let serial = disk.serial().map(|s| s.to_string_lossy().into_owned());
let devpath = disk.device_path().map(|p| p.to_owned())
.map(|p| p.to_string_lossy().to_string());
let wwn = disk.wwn().map(|s| s.to_string_lossy().into_owned());
if usage != DiskUsageType::Mounted {
match scan_partitions(disk_manager.clone(), &lvm_devices, &zfs_devices, &name) {
Ok(part_usage) => {
if part_usage != DiskUsageType::Unused {
usage = part_usage;
}
},
Err(_) => continue, // skip devices if scan_partitions fail
};
}
let mut status = SmartStatus::Unknown;
let mut wearout = None;
if !no_smart {
if let Ok(smart) = get_smart_data(&disk, false) {
status = smart.status;
wearout = smart.wearout;
}
}
let info = DiskUsageInfo {
name: name.clone(),
vendor, model, serial, devpath, size, wwn, disk_type,
status, wearout,
used: usage,
gpt: disk.has_gpt(),
rpm: disk.ata_rotation_rate_rpm(),
};
result.insert(name, info);
}
Ok(result)
}
/// Initialize disk by writing a GPT partition table
pub fn inititialize_gpt_disk(disk: &Disk, uuid: Option<&str>) -> Result<(), Error> {
const SGDISK_BIN_PATH: &str = "/usr/sbin/sgdisk";
let disk_path = match disk.device_path() {
Some(path) => path,
None => bail!("disk {:?} has no node in /dev", disk.syspath()),
};
let uuid = uuid.unwrap_or("R"); // R .. random disk GUID
let mut command = std::process::Command::new(SGDISK_BIN_PATH);
command.arg(disk_path);
command.args(&["-U", uuid]);
let output = command.output()
.map_err(|err| format_err!("failed to execute '{}' - {}", SGDISK_BIN_PATH, err))?;
crate::tools::command_output(output, None)
.map_err(|err| format_err!("sgdisk command failed: {}", err))?;
Ok(())
}
/// Block device name completion helper
pub fn complete_disk_name(_arg: &str, _param: &HashMap<String, String>) -> Vec<String> {
let mut list = Vec::new();
let dir = match crate::tools::fs::scan_subdir(libc::AT_FDCWD, "/sys/block", &BLOCKDEVICE_NAME_REGEX) {
Ok(dir) => dir,
Err(_) => return list,
};
for item in dir {
if let Ok(item) = item {
let name = item.file_name().to_str().unwrap().to_string();
list.push(name);
}
}
list
}