tyler/proxmox-backup
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
4,335 Commits 2 Branches 54 Tags 14 MiB
f91481eded
Commit Graph

426 Commits

Author SHA1 Message Date
Thomas Lamprecht
f91481eded ui: rework TFA prompt on login 
Improve UX by avoiding the need to click some buttons twice, or
calling TOTP and Recovery codes both "OTP" codes and showing multiple
buttons, with all having the same goal "submit a TFA token" at the
same time.

Instead use a tab panel with a single submit button.

WebAuthn can and should be still improved, but that can be OK as
followup.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-27 13:21:25 +01:00
Oguz Bektas
d43265b7f1 ui: add missing uri encoding in user edit and view 
userid parameter needs to be properly encoded when shown on the browser

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
 2021-01-26 10:53:30 +01:00
Dietmar Maurer
697c41c584 tape: add/use rust scsi changer implementation using libsgutil2 2021-01-25 13:14:07 +01:00
Thomas Lamprecht
aab9a26409 ui: cleanup order of declraing properties 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-21 15:09:22 +01:00
Thomas Lamprecht
958055a789 ui: fix on-parse use of global Proxmox.UserName 
This is wrong most of the time, when not loading the web interface
with valid credentials, and thus some checks or defaults did not
evaluated correctly when the underlying value was only set later.

Needs to be set on component creation only, this can be done through
initComponent, even listeners, view controllers or cbind closures.

Use the latter, as all affected components already use cbind.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-21 15:08:46 +01:00
Thomas Lamprecht
0123039271 ui: tfa: rework removal confirmation dialog 
present all relevant information about the TFA token to be removed,
so that a user can make a better decision.

Rework layout to match our commonly used style.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-19 19:46:10 +01:00
Thomas Lamprecht
9a0e115a37 ui: tfa view: add userid to TFA data model 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-19 19:46:10 +01:00
Thomas Lamprecht
867bfc4378 ui: login view: fix missing trailing comma 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-19 19:46:10 +01:00
Thomas Lamprecht
ac163a7c18 ui: tfa/totp: fix setting issuer in secret URL 
it's recommended to set the issuer for both, the get parameter and
the initial issuer label prefix[0].

[0]: https://github.com/google/google-authenticator/wiki/Key-Uri-Format#label

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-18 16:27:02 +01:00
Thomas Lamprecht
f57ae48286 ui: tfa: fix ctime column width 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-18 14:31:15 +01:00
Wolfgang Bumiller
4cbd7eb7f9 gui: tfa: make description fill the remaining space 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2021-01-18 14:06:12 +01:00
Wolfgang Bumiller
310686726a gui: tfa: show when entries were created 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2021-01-18 14:06:12 +01:00
Wolfgang Bumiller
8ae6d28cd4 gui: enumerate recovery keys and list in 2nd factor window 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2021-01-18 13:51:23 +01:00
Thomas Lamprecht
4e9cc3e97c ui: tfa: fix title for removal confirmation 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-18 13:28:02 +01:00
Thomas Lamprecht
492bc2ba63 ui: tfa/recovery: add print button to key info window 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-18 10:45:47 +01:00
Thomas Lamprecht
995492100a ui: tfa/recovery: fix copy button text, add icon 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-18 10:45:28 +01:00
Thomas Lamprecht
854319d88c ui: tfa/recovery: disallow to close key info window with ESC 
to avoid accidental closing it

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-18 10:44:40 +01:00
Thomas Lamprecht
3189d05134 ui: tfa: specify which confirmation password is required 
Clarify that the password of the user one wants to add TFA too is
required, which is not necessarily the one of the current logged in
user. Use an empty text for that.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-18 10:12:23 +01:00
Thomas Lamprecht
b2a43b987c ui: tfa totp: whitespace and padding fix 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-18 10:10:16 +01:00
Thomas Lamprecht
6676409f7f ui: access: stream line add/edit/.. button order and separators 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-18 09:33:29 +01:00
Thomas Lamprecht
a9ffa010c8 ui: webauthn config: set default values for unconfigured case 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-15 16:25:47 +01:00
Thomas Lamprecht
a6a903293b ui: webauthn config: use ID instead of Id/id 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-15 16:25:26 +01:00
Wolfgang Bumiller
3fffcb5d77 gui: tfa configuration 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2021-01-15 15:19:52 +01:00
Dominik Csapak
646221cc29 ui: window/{AddWebauthn, TfaEdit}: fix spacing/border of the windows 
the password field should not be indented differently than the rest of
the fields, and we never have a border on the panels

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2021-01-13 16:46:47 +01:00
Dominik Csapak
b168a27f73 ui: window/AddTotp: fix spacing styling of form fields 
by moving the lower fields into the form itself and dropping the padding

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2021-01-13 16:46:47 +01:00
Dominik Csapak
a442bd9792 ui: window/AddTfaRecovery: fix style of TfaRecoveryShow window 
to have a more similar layout/spacing to our other windows

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2021-01-13 16:46:47 +01:00
Dominik Csapak
884fec7735 ui: window/AddTfaRecovery: rewrite to a Proxmox.window.Edit 
we can reuse the edit window from widget toolkit for the most part
this solves some spacing and layout issues and is less code

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2021-01-13 16:46:47 +01:00
Dominik Csapak
1cb89f302f ui: config/TfaView: disable Remove button by default 
gets enabled when an item is clicked

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2021-01-13 16:46:47 +01:00
Dominik Csapak
da36bbe756 ui: LoginView: remove not used viewModel 
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2021-01-13 16:46:47 +01:00
Thomas Lamprecht
d91c6fd4e1 ui: tfa: drop bogus gettext of empty string 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-12 11:44:05 +01:00
Dominic Jäger
711d1f6fc3 ui: notify options: Remove gettext for root@pam 
Translating root@pam is not useful, especially as the empty text symbolises the
default value.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
 2021-01-12 11:41:24 +01:00
Dominik Csapak
e422beec74 fix #3245: only use default schedule for new jobs 
an empty schedule means 'none', so do not fill it with the default
in case we edit an existing job (like we do already for sync jobs)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2021-01-12 10:26:59 +01:00
Wolfgang Bumiller
63fd8e58b2 gui: masks for: adding recovery and removals 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2021-01-11 10:23:13 +01:00
Wolfgang Bumiller
758a827c2d gui: add load mask during webauthn api calls 
so that if we run into the 3s delay due to the wrong
password the window is properly masked

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2021-01-11 10:23:13 +01:00
Wolfgang Bumiller
5c48d0af1f tfa gui: fix adding recovery keys as user 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2021-01-11 10:22:32 +01:00
Wolfgang Bumiller
30fb19be35 tfa view: html-escape description text 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2021-01-11 10:22:32 +01:00
Wolfgang Bumiller
fbeac4ea28 gui: tfa support 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2021-01-11 10:22:32 +01:00
Dominic Jäger
f54cd66924 ui: running tasks: Use gettext for column labels 
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
 2021-01-05 13:53:33 +01:00
Dietmar Maurer
1835d86e9d gui: update tape job descriptions 2020-12-31 10:37:09 +01:00
Dietmar Maurer
73b8f6793e tape: add svg icon 2020-12-11 13:02:23 +01:00
Dietmar Maurer
663ef85992 tape: use WorkerTask for erase and rewind 2020-12-11 11:19:33 +01:00
Dietmar Maurer
e92c75815b tape: split inventory api 
inventory: sync, list labels with uuids,
update_inventory: WorkerTask, updates database
 2020-12-11 10:42:29 +01:00
Dietmar Maurer
6dbad5b4b5 tape: run label commands as WorkerTask (threads) 2020-12-11 09:10:22 +01:00
Dietmar Maurer
ff50c07ebf start experimental tape management GUI 
You need to set the environment TEST_TAPE_GUI=1 to enable this.
The current GUI is only a placeholder.
 2020-12-04 12:50:08 +01:00
Dominik Csapak
781106f8c5 ui: fix usage of findRecord 
findRecord does not match exactly, but only at the beginning and
case insensitive, by default. Change all calls to be case sensitive
and an exactmatch (we never want the default behaviour afaics).

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2020-11-27 07:20:32 +01:00
Thomas Lamprecht
5176346b30 ui: fix broken gettext use 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-25 00:21:17 +01:00
Fabian Grünbichler
6982a54701 gui: add snapshot/file fingerprint tooltip 
display short key ID, like backend's Display trait.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
 2020-11-24 08:44:55 +01:00
Dietmar Maurer
6364115b4b OnlineHelpInfo.js problems 
Anybody known why I always get the following diff:
 2020-11-23 12:57:41 +01:00
Thomas Lamprecht
01f84fcce1 ui: datastore content: use our keep field for group pruning 
sets some defaults and provides the clear trigger, so less code and
slightly nicer UX.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-21 19:52:03 +01:00
Fabian Grünbichler
98afc7b152 api: make expensive parts of datastore status opt-in 
used in the PBS GUI, but also for PVE usage queries which don't need all
the extra expensive information..

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
 2020-11-18 11:05:47 +01:00