tyler/proxmox-backup
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
4,387 Commits 2 Branches 54 Tags
b22c618734c9909e5da11c73b8be1e92a7dea3a2
Commit Graph
94 Commits
Author SHA1 Message Date
Oguz BektasandWolfgang Bumiller d43265b7f1 ui: add missing uri encoding in user edit and view 
userid parameter needs to be properly encoded when shown on the browser

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
 2021-01-26 10:53:30 +01:00
Thomas Lamprecht aab9a26409 ui: cleanup order of declraing properties 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-21 15:09:22 +01:00
Thomas Lamprecht 958055a789 ui: fix on-parse use of global Proxmox.UserName 
This is wrong most of the time, when not loading the web interface
with valid credentials, and thus some checks or defaults did not
evaluated correctly when the underlying value was only set later.

Needs to be set on component creation only, this can be done through
initComponent, even listeners, view controllers or cbind closures.

Use the latter, as all affected components already use cbind.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-21 15:08:46 +01:00
Thomas Lamprecht ac163a7c18 ui: tfa/totp: fix setting issuer in secret URL 
it's recommended to set the issuer for both, the get parameter and
the initial issuer label prefix[0].

[0]: https://github.com/google/google-authenticator/wiki/Key-Uri-Format#label

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-18 16:27:02 +01:00
Wolfgang BumillerandThomas Lamprecht 8ae6d28cd4 gui: enumerate recovery keys and list in 2nd factor window 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2021-01-18 13:51:23 +01:00
Thomas Lamprecht 492bc2ba63 ui: tfa/recovery: add print button to key info window 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-18 10:45:47 +01:00
Thomas Lamprecht 995492100a ui: tfa/recovery: fix copy button text, add icon 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-18 10:45:28 +01:00
Thomas Lamprecht 854319d88c ui: tfa/recovery: disallow to close key info window with ESC 
to avoid accidental closing it

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-18 10:44:40 +01:00
Thomas Lamprecht 3189d05134 ui: tfa: specify which confirmation password is required 
Clarify that the password of the user one wants to add TFA too is
required, which is not necessarily the one of the current logged in
user. Use an empty text for that.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-18 10:12:23 +01:00
Thomas Lamprecht b2a43b987c ui: tfa totp: whitespace and padding fix 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2021-01-18 10:10:16 +01:00
Dominik CsapakandThomas Lamprecht 646221cc29 ui: window/{AddWebauthn, TfaEdit}: fix spacing/border of the windows 
the password field should not be indented differently than the rest of
the fields, and we never have a border on the panels

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2021-01-13 16:46:47 +01:00
Dominik CsapakandThomas Lamprecht b168a27f73 ui: window/AddTotp: fix spacing styling of form fields 
by moving the lower fields into the form itself and dropping the padding

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2021-01-13 16:46:47 +01:00
Dominik CsapakandThomas Lamprecht a442bd9792 ui: window/AddTfaRecovery: fix style of TfaRecoveryShow window 
to have a more similar layout/spacing to our other windows

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2021-01-13 16:46:47 +01:00
Dominik CsapakandThomas Lamprecht 884fec7735 ui: window/AddTfaRecovery: rewrite to a Proxmox.window.Edit 
we can reuse the edit window from widget toolkit for the most part
this solves some spacing and layout issues and is less code

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2021-01-13 16:46:47 +01:00
Dominic JägerandThomas Lamprecht 711d1f6fc3 ui: notify options: Remove gettext for root@pam 
Translating root@pam is not useful, especially as the empty text symbolises the
default value.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
 2021-01-12 11:41:24 +01:00
Dominik CsapakandDietmar Maurer e422beec74 fix #3245: only use default schedule for new jobs 
an empty schedule means 'none', so do not fill it with the default
in case we edit an existing job (like we do already for sync jobs)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2021-01-12 10:26:59 +01:00
Wolfgang Bumiller 63fd8e58b2 gui: masks for: adding recovery and removals 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2021-01-11 10:23:13 +01:00
Wolfgang Bumiller 758a827c2d gui: add load mask during webauthn api calls 
so that if we run into the 3s delay due to the wrong
password the window is properly masked

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2021-01-11 10:23:13 +01:00
Wolfgang Bumiller 5c48d0af1f tfa gui: fix adding recovery keys as user 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2021-01-11 10:22:32 +01:00
Wolfgang Bumiller fbeac4ea28 gui: tfa support 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2021-01-11 10:22:32 +01:00
Thomas Lamprecht 01f84fcce1 ui: datastore content: use our keep field for group pruning 
sets some defaults and provides the clear trigger, so less code and
slightly nicer UX.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-21 19:52:03 +01:00
Dominik CsapakandThomas Lamprecht c0026563b0 make user properties deletable 
by using our usual pattern for the update call

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2020-11-11 14:09:40 +01:00
Thomas Lamprecht 03e40aa4ee ui: datastore add: set default schedule 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-11 07:49:01 +01:00
Thomas Lamprecht be1d6cbcc6 ui: shorten automatic ID length a bit 
Without hyphens, we had 20 hex digits, so ~80 bit which is probably overkill.
Use 12 (13 with hyphen), this is still 48 bit.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-11 07:40:23 +01:00
Fabian GrünbichlerandThomas Lamprecht 10052ea644 remote.cfg: rename userid to 'auth-id' 
and fixup config file on upgrades accordingly

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
 2020-11-10 13:25:24 +01:00
Aaron LautererandThomas Lamprecht 133de2dd1f ui: add/fix help buttons 
added a few more help buttons were appropriate:

* GC and Prune schedule windows
* Create Directory window
* API Tokens, link directly to token section
* verify jobs window

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
 2020-11-10 11:51:03 +01:00
Thomas Lamprecht 5c64e83b1e ui: datastore: set onlineHelp for chaging group owner 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-10 09:53:05 +01:00
Thomas Lamprecht d89f91b538 ui: acl editor: disallow path editing for datastore permission views 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-10 08:19:17 +01:00
Dominik CsapakandThomas Lamprecht ab81bb13ad ui: make Sync/VerifyView and Edit usable without datastore 
we want to use this panel again for a 'global' overview, without
any datastore preselected, so we have to handle that, and
adding a datastore selector in the editwindow

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2020-11-09 16:37:24 +01:00
Thomas Lamprecht 6d5803399b ui: add some onlineHelp reference uses for pruning 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-07 16:03:07 +01:00
Thomas Lamprecht d669a739b2 ui: datastore: backup owner change: fix layout 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-06 19:48:08 +01:00
Thomas Lamprecht c7fa61619e ui: move backup group owner changer into window folder 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-06 19:47:45 +01:00
Fabian GrünbichlerandThomas Lamprecht d923671a7b ui: use AuthidSelector for sync job owner 
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
 2020-11-06 19:06:34 +01:00
Thomas Lamprecht 65595e169f ui: add NotifyOptions edit window 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-06 17:52:15 +01:00
Dietmar Maurer 1b37ebf6f6 ui: require owner for sync jobs 2020-11-06 08:48:07 +01:00
Dietmar Maurer ad54df3178 get rid of backup@pam 2020-11-06 08:39:30 +01:00
Fabian GrünbichlerandThomas Lamprecht ae8635c307 www: add remote store selector 
(hopefully) improved upon NFS export selection in PVE

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
 2020-11-05 12:56:20 +01:00
Thomas Lamprecht 4935681cf4 ui: sync jobs: add tooltip for remove vanished 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-04 19:07:07 +01:00
Thomas Lamprecht 669fa672d9 ui: sync jobs: reorder fields 
group local ones togeteher on the left side, and source + schedule
on the right side.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-04 19:05:48 +01:00
Thomas Lamprecht a797583535 ui: sync jobs: fix originalValue of owner and improve label 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-04 19:04:42 +01:00
Thomas Lamprecht 54ed1b2a71 ui: sync jobs: only set default schedule when creating new jobs 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-04 19:04:06 +01:00
Dominik CsapakandThomas Lamprecht 84006f98b2 ui: SyncJobEdit: fix sending 'delete' values on SyncJob creation 
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2020-11-04 11:39:52 +01:00
Fabian GrünbichlerandDietmar Maurer f1694b062d fix #2864: add owner option to sync 
instead of hard-coding 'backup@pam'. this allows a bit more flexibility
(e.g., syncing to a datastore that can directly be used as restore
source) without overly complicating things.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
 2020-11-02 07:08:05 +01:00
Fabian GrünbichlerandThomas Lamprecht 8b600f9965 api: replace auth_id with auth-id 
in parameters, and fix up the completion for the ACL update parameter.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
 2020-10-30 16:46:19 +01:00
Fabian GrünbichlerandWolfgang Bumiller 184a37635b gui: add API token ACLs 
and the needed API token selector.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
 2020-10-29 15:14:27 +01:00
Fabian GrünbichlerandWolfgang Bumiller 7fe76d3491 gui: add API token UI 
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
 2020-10-29 15:14:27 +01:00
Fabian GrünbichlerandWolfgang Bumiller e6dc35acb8 replace Userid with Authid 
in most generic places. this is accompanied by a change in
RpcEnvironment to purposefully break existing call sites.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
 2020-10-29 15:11:39 +01:00
Thomas Lamprecht ab0cf7e6a1 ui: drop id field from verify/sync add window 
the config is shared between multiple datastores with the ID as, well
the unique ID, but we only show those of a single datastore.

So if a user adds a new one with a fixed ID "12345" but a job with
that ID exists already on another store, they get a error about
duplicate IDs, but cannot relate as that duplicate job is not visible
(filtered away)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-10-29 14:22:43 +01:00
Thomas Lamprecht 319fe45261 ui: datastore: rework sync layout, make job ID optional 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-10-28 21:25:30 +01:00
Thomas Lamprecht f26080fab1 ui: datastore: rework verify layout, make job ID optional 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-10-28 21:25:07 +01:00