tyler
/
proxmox-backup
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix #3393: tools/xattr: allow xattr 'security.NTACL' 

in some configurations, samba stores NTFS-ACLs in this xattr[0], so
we should backup (if we can)

altough the 'security' namespace is special (e.g. in use by
selinux, etc.) this value is normally only used by samba and we
should be able to back it up.

to restore it, the user needs at least 'CAP_SYS_ADMIN' rights, otherwise
it cannot be set

0: https://www.samba.org/samba/docs/current/man-html/vfs_acl_xattr.8.html

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2021-04-20 11:19:53 +02:00 committed by Wolfgang Bumiller
parent 71e83e1b1f
commit fea23d0323
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/tools/xattr.rs
View File

@ -170,6 +170,10 @@ pub fn is_valid_xattr_name(c_name: &CStr) -> bool {
if name.starts_with(b"user.") || name.starts_with(b"trusted.") { if name.starts_with(b"user.") || name.starts_with(b"trusted.") {
return true; return true;
} }
// samba saves windows ACLs there
if name == b"security.NTACL" {
return true;
}
is_security_capability(c_name) is_security_capability(c_name)
} }