From fb66c85363cf3026bbf1b2e726333ef03263c738 Mon Sep 17 00:00:00 2001
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Sat, 31 Oct 2020 10:54:14 +0100
Subject: [PATCH] ui: improve sync job view layout

Avoid overuse of flex, that is as bad as having all to fixed widths.

In spirit similar to the previous commit for the verify panel, see
that for some rationale.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 www/config/SyncView.js | 37 ++++++++++++++++++++-----------------
 1 file changed, 20 insertions(+), 17 deletions(-)

diff --git a/www/config/SyncView.js b/www/config/SyncView.js
index 0f68555b..f95823a6 100644
--- a/www/config/SyncView.js
+++ b/www/config/SyncView.js
@@ -224,68 +224,71 @@ Ext.define('PBS.config.SyncJobView', {
 
     columns: [
 	{
-	    header: gettext('Sync Job'),
+	    header: gettext('Job ID'),
 	    dataIndex: 'id',
 	    renderer: Ext.String.htmlEncode,
-	    flex: 2,
+	    maxWidth: 220,
+	    minWidth: 75,
+	    flex: 1,
 	    sortable: true,
-	    hidden: true,
 	},
 	{
 	    header: gettext('Remote'),
 	    dataIndex: 'remote',
-	    flex: 2,
+	    width: 120,
 	    sortable: true,
 	},
 	{
 	    header: gettext('Remote Store'),
 	    dataIndex: 'remote-store',
-	    flex: 2,
+	    width: 120,
 	    sortable: true,
 	},
 	{
 	    header: gettext('Local Store'),
 	    dataIndex: 'store',
-	    flex: 2,
+	    width: 120,
 	    sortable: true,
 	},
 	{
 	    header: gettext('Schedule'),
 	    dataIndex: 'schedule',
-	    flex: 2,
+	    maxWidth: 220,
+	    minWidth: 80,
+	    flex: 1,
 	    sortable: true,
 	},
-	{
-	    header: gettext('Status'),
-	    dataIndex: 'last-run-state',
-	    renderer: 'render_sync_status',
-	    flex: 4,
-	},
 	{
 	    header: gettext('Last Sync'),
 	    dataIndex: 'last-run-endtime',
 	    renderer: 'render_optional_timestamp',
-	    flex: 3,
+	    width: 150,
 	    sortable: true,
 	},
 	{
 	    text: gettext('Duration'),
 	    dataIndex: 'duration',
 	    renderer: Proxmox.Utils.render_duration,
-	    flex: 2,
+	    width: 80,
+	},
+	{
+	    header: gettext('Status'),
+	    dataIndex: 'last-run-state',
+	    renderer: 'render_sync_status',
+	    flex: 3,
 	},
 	{
 	    header: gettext('Next Run'),
 	    dataIndex: 'next-run',
 	    renderer: 'render_next_run',
-	    flex: 3,
+	    width: 150,
 	    sortable: true,
 	},
 	{
 	    header: gettext('Comment'),
 	    dataIndex: 'comment',
 	    renderer: Ext.String.htmlEncode,
-	    flex: 4,
+	    flex: 2,
 	    sortable: true,
 	},
     ],