From ef496e2c203a4ef3c05476c272c67fd16fcdc3cd Mon Sep 17 00:00:00 2001
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Tue, 21 Jul 2020 18:46:55 +0200
Subject: [PATCH] ui: sync job: group remote fields and use "Source" in labels

Using "Source" helps to understand that this is a "pull from remote"
sync, not a "push to remote" one.

https://forum.proxmox.com/threads/suggestions-regarding-configurations-terminology.73272/

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 www/window/SyncJobEdit.js | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
index 2759716c..1c8a6656 100644
--- a/www/window/SyncJobEdit.js
+++ b/www/window/SyncJobEdit.js
@@ -28,7 +28,7 @@ Ext.define('PBS.window.SyncJobEdit', {
 	xtype: 'inputpanel',
 	column1: [
 	    {
-		fieldLabel: gettext('Sync Job'),
+		fieldLabel: gettext('Sync Job ID'),
 		xtype: 'pmxDisplayEditField',
 		name: 'id',
 		renderer: Ext.htmlEncode,
@@ -39,23 +39,23 @@ Ext.define('PBS.window.SyncJobEdit', {
 		},
 	    },
 	    {
-		fieldLabel: gettext('Remote'),
+		fieldLabel: gettext('Source Remote'),
 		xtype: 'pbsRemoteSelector',
 		allowBlank: false,
 		name: 'remote',
 	    },
+	    {
+		fieldLabel: gettext('Source Datastore'),
+		xtype: 'proxmoxtextfield',
+		allowBlank: false,
+		name: 'remote-store',
+	    },
 	    {
 		fieldLabel: gettext('Local Datastore'),
 		xtype: 'pbsDataStoreSelector',
 		allowBlank: false,
 		name: 'store',
 	    },
-	    {
-		fieldLabel: gettext('Remote Datastore'),
-		xtype: 'proxmoxtextfield',
-		allowBlank: false,
-		name: 'remote-store',
-	    },
 	],
 
 	column2: [
@@ -70,6 +70,7 @@ Ext.define('PBS.window.SyncJobEdit', {
 		fieldLabel: gettext('Schedule'),
 		xtype: 'proxmoxtextfield',
 		name: 'schedule',
+		emptyText: gettext('none'),
 		cbind: {
 		    deleteEmpty: '{!isCreate}',
 		},