tyler/proxmox-backup
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

REST: set error message extenesion for bad-request response log

Browse Source 
We send it already to the user via the response body, but the
log_response does not has, nor wants to have FWIW, access to the
async body stream, so pass it through the ErrorMessageExtension
mechanism like we do else where.

Note that this is not only useful for PBS API proxy/daemon but also
the REST server of the file-restore daemon running inside the restore
VM, and it really is *very* helpful to debug things there..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
(cherry picked from commit f4d371d2d2c5d79352e9681b5d942627e26c6fd4)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2021-07-03 20:49:16 +02:00
parent 0fad95f032
commit e9c2a34def
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/server/rest.rs
View File

@ -253,7 +253,10 @@ impl tower_service::Service<Request<Body>> for ApiService {
Some(apierr) => (apierr.message.clone(), apierr.code), Some(apierr) => (apierr.message.clone(), apierr.code),
_ => (err.to_string(), StatusCode::BAD_REQUEST), _ => (err.to_string(), StatusCode::BAD_REQUEST),
}; };
Response::builder().status(code).body(err.into())? Response::builder()
.status(code)
.extension(ErrorMessageExtension(err.to_string()))
.body(err.into())?
} }
}; };
let logger = config.get_file_log(); let logger = config.get_file_log();