clippy: us *_or_else with function calls

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>

src/server/email_notifications.rs

@@ -456,7 +456,7 @@ fn handlebars_humam_bytes_helper(
 ) -> HelperResult {
     let param = h.param(0).map(|v| v.value().as_u64())
         .flatten()
-        .ok_or(RenderError::new("human-bytes: param not found"))?;
+        .ok_or_else(|| RenderError::new("human-bytes: param not found"))?;
 
     out.write(&HumanByte::from(param).to_string())?;
 
@@ -472,10 +472,10 @@ fn handlebars_relative_percentage_helper(
 ) -> HelperResult {
     let param0 = h.param(0).map(|v| v.value().as_f64())
         .flatten()
-        .ok_or(RenderError::new("relative-percentage: param0 not found"))?;
+        .ok_or_else(|| RenderError::new("relative-percentage: param0 not found"))?;
     let param1 = h.param(1).map(|v| v.value().as_f64())
         .flatten()
-        .ok_or(RenderError::new("relative-percentage: param1 not found"))?;
+        .ok_or_else(|| RenderError::new("relative-percentage: param1 not found"))?;
 
     if param1 == 0.0 {
         out.write("-")?;

src/server/rest.rs

@@ -147,7 +147,7 @@ fn log_response(
         let now = proxmox::tools::time::epoch_i64();
         // time format which apache/nginx use (by default), copied from pve-http-server
         let datetime = proxmox::tools::time::strftime_local("%d/%m/%Y:%H:%M:%S %z", now)
-            .unwrap_or("-".into());
+            .unwrap_or_else(|_| "-".to_string());
 
         logfile
             .lock()
@@ -161,7 +161,7 @@ fn log_response(
                 path,
                 status.as_str(),
                 resp.body().size_hint().lower(),
-                user_agent.unwrap_or("-".into()),
+                user_agent.unwrap_or_else(|| "-".to_string()),
             ));
     }
 }

src/server/worker_task.rs

@@ -330,7 +330,7 @@ pub fn rotate_task_log_archive(size_threshold: u64, compress: bool, max_files: O
     let _lock = lock_task_list_files(true)?;
 
     let mut logrotate = LogRotate::new(PROXMOX_BACKUP_ARCHIVE_TASK_FN, compress)
-        .ok_or(format_err!("could not get archive file names"))?;
+        .ok_or_else(|| format_err!("could not get archive file names"))?;
 
     logrotate.rotate(size_threshold, None, max_files)
 }