From dda1b4fa446241d2cbc876a026f2e2bd9dbda704 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= Date: Mon, 10 May 2021 10:52:31 +0200 Subject: [PATCH] fix #3391: improve mismatched fingerprint handling MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit if the expected fingerprint and the one returned by the server don't match, print a warning and allow confirmation and proceeding if running interactive. previous: $ proxmox-backup-client ... Error: error trying to connect: error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1915: new: $ proxmox-backup-client ... WARNING: certificate fingerprint does not match expected fingerprint! expected: ac:cb:6a:bc:d6:b7:b4:77:3e:17:05:d6:b6:29:dd:1f:05:9c:2b:3a:df:84:3b:4d:f9:06:2c:be:da:06:52:12 fingerprint: ab:cb:6a:bc:d6:b7:b4:77:3e:17:05:d6:b6:29:dd:1f:05:9c:2b:3a:df:84:3b:4d:f9:06:2c:be:da:06:52:12 Are you sure you want to continue connecting? (y/n): n Error: error trying to connect: error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1915: Signed-off-by: Fabian Grünbichler --- src/client/http_client.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/client/http_client.rs b/src/client/http_client.rs index c8d1f743..1df22dc9 100644 --- a/src/client/http_client.rs +++ b/src/client/http_client.rs @@ -498,10 +498,12 @@ impl HttpClient { .collect::>().join(":"); if let Some(expected_fingerprint) = expected_fingerprint { - if expected_fingerprint.to_lowercase() == fp_string { + let expected_fingerprint = expected_fingerprint.to_lowercase(); + if expected_fingerprint == fp_string { return (true, Some(fp_string)); } else { - return (false, None); + eprintln!("WARNING: certificate fingerprint does not match expected fingerprint!"); + eprintln!("expected: {}", expected_fingerprint); } }