make datastore BackupGroup/Dir ctors private

And use the api-types for their contents.

These are supposed to be instances for a datastore, the pure
specifications are the ones in pbs_api_types which should be
preferred in crates like clients which do not need to deal
with the datastore directly.

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>

pbs-datastore/src/snapshot_reader.rs

@@ -28,8 +28,13 @@ pub struct SnapshotReader {
 
 impl SnapshotReader {
     /// Lock snapshot, reads the manifest and returns a new instance
-    pub fn new(datastore: Arc<DataStore>, snapshot: BackupDir) -> Result<Self, Error> {
-        let snapshot_path = datastore.snapshot_path(&snapshot);
+    pub fn new(
+        datastore: Arc<DataStore>,
+        snapshot: pbs_api_types::BackupDir,
+    ) -> Result<Self, Error> {
+        let snapshot = datastore.backup_dir_from_spec(snapshot)?;
+
+        let snapshot_path = snapshot.full_path(datastore.base_path());
 
         let locked_dir =
             lock_dir_noblock_shared(&snapshot_path, "snapshot", "locked by another operation")?;