s/pbsbanner/proxmox-backup-banner/ + move to /usr/lib

We want to avoid pbs if possible and also avoid placing internal
binaries, not intended for human direct use, in /bin or /sbin paths.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

Makefile

@@ -12,12 +12,13 @@ USR_BIN := \
 	pxar
 
 # Binaries usable by admins
-USR_SBIN := proxmox-backup-manager \
-	pbsbanner
+USR_SBIN := \
+	proxmox-backup-manager
 
 # Binaries for services:
 SERVICE_BIN := \
 	proxmox-backup-api \
+	proxmox-backup-banner \
 	proxmox-backup-proxy
 
 ifeq ($(BUILD_MODE), release)

debian/proxmox-backup-server.install

@@ -1,10 +1,10 @@
 etc/proxmox-backup-proxy.service /lib/systemd/system/
 etc/proxmox-backup.service /lib/systemd/system/
-etc/pbsbanner.service /lib/systemd/system/
+etc/proxmox-backup-banner.service /lib/systemd/system/
 usr/lib/x86_64-linux-gnu/proxmox-backup/proxmox-backup-api
 usr/lib/x86_64-linux-gnu/proxmox-backup/proxmox-backup-proxy
+usr/lib/x86_64-linux-gnu/proxmox-backup/proxmox-backup-banner
 usr/sbin/proxmox-backup-manager
-usr/sbin/pbsbanner
 usr/share/javascript/proxmox-backup/css/ext6-pbs.css
 usr/share/javascript/proxmox-backup/images/logo-128.png
 usr/share/javascript/proxmox-backup/images/proxmox_logo.png

etc/Makefile

@@ -1,9 +1,9 @@
 include ../defines.mk
 
-UNITS := \
-	pbsbanner.service \
+UNITS :=
 
 DYNAMIC_UNITS := \
+	proxmox-backup-banner.service \
 	proxmox-backup.service \
 	proxmox-backup-proxy.service
 

etc/proxmox-backup-banner.service.in

@@ -1,13 +1,13 @@
 [Unit]
 Description=Proxmox Backup Server Login Banner
-ConditionPathExists=/usr/sbin/pbsbanner
+ConditionPathExists=%LIBEXECDIR%/proxmox-backup/proxmox-backup-banner
 ConditionPathExists=!/usr/bin/pvebanner
 DefaultDependencies=no
 After=local-fs.target
 Before=console-getty.service
 
 [Service]
-ExecStart=/usr/sbin/pbsbanner
+ExecStart=%LIBEXECDIR%/proxmox-backup/proxmox-backup-banner
 Type=oneshot
 RemainAfterExit=yes
 

src/bin/proxmox-backup-banner.rs

@@ -8,7 +8,8 @@ fn main() {
     let nodename = tools::nodename();
     let addr = format!("{}:8007", nodename);
 
-    let mut banner = format!("
+    let mut banner = format!(
+        "
 {:-<78}
 
 Welcome to the Proxmox Backup Server. Please use your web browser to
@@ -30,9 +31,12 @@ configure this server - connect to:
             if !saddrs.is_empty() {
                 saddrs.join("\n")
             } else {
-                format!("hostname '{}' does not resolves to any non-loopback address", nodename)
+                format!(
+                    "hostname '{}' does not resolves to any non-loopback address",
+                    nodename
+                )
+            }
         }
-        },
         Err(e) => format!("could not resolve hostname '{}': {}", nodename, e),
     };
     banner += &msg;