tyler
/
proxmox-backup
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ui: LoginView: show webauthn errors in window 

instead of silently discarding the error, else the user might be
confused because nothing happened

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2021-02-25 10:01:22 +01:00 committed by Thomas Lamprecht
parent 831c43c91b
commit a8a0132766
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
www/LoginView.js
View File

@ -383,6 +383,7 @@ Ext.define('PBS.login.TfaWindow', {
let view = me.getView(); let view = me.getView();
me.lookup('webAuthnWaiting').setVisible(true); me.lookup('webAuthnWaiting').setVisible(true);
me.lookup('webAuthnError').setVisible(false);
let challenge = view.challenge.webauthn; let challenge = view.challenge.webauthn;
@ -409,6 +410,10 @@ Ext.define('PBS.login.TfaWindow', {
// checking for error.code === DOMException.ABORT_ERR only works in firefox -.- // checking for error.code === DOMException.ABORT_ERR only works in firefox -.-
this.getViewModel().set('canConfirm', true); this.getViewModel().set('canConfirm', true);
// FIXME: better handling, show some message, ...? // FIXME: better handling, show some message, ...?
me.lookup('webAuthnError').setData({
error: Ext.htmlEncode(error.toString()),
});
me.lookup('webAuthnError').setVisible(true);
return; return;
} finally { } finally {
let waitingMessage = me.lookup('webAuthnWaiting'); let waitingMessage = me.lookup('webAuthnWaiting');
@ -505,6 +510,15 @@ Ext.define('PBS.login.TfaWindow', {
reference: 'webAuthnWaiting', reference: 'webAuthnWaiting',
hidden: true, hidden: true,
}, },
{
xtype: 'box',
data: {
error: '',
},
tpl: '<i class="fa fa-warning warning"></i> {error}',
reference: 'webAuthnError',
hidden: true,
},
], ],
}, },
{ {