From 9d5b426a6dd13b2cd6f0a6678e23fef9141ae664 Mon Sep 17 00:00:00 2001 From: Dominik Csapak Date: Tue, 2 Mar 2021 12:19:37 +0100 Subject: [PATCH] ui: tape: refactor renderDriveState to Utils we will use this later again Signed-off-by: Dominik Csapak --- www/Utils.js | 16 ++++++++++++++++ www/tape/ChangerStatus.js | 18 +----------------- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/www/Utils.js b/www/Utils.js index c531edbb..778dad24 100644 --- a/www/Utils.js +++ b/www/Utils.js @@ -603,6 +603,22 @@ Ext.define('PBS.Utils', { }).show(); }, + renderDriveState: function(value, md) { + if (!value) { + return gettext('Idle'); + } + + let icon = ''; + + if (value.startsWith("UPID")) { + let upid = Proxmox.Utils.parse_task_upid(value); + md.tdCls = "pointer"; + return `${icon} ${upid.desc}`; + } + + return `${icon} ${value}`; + }, + }); Ext.define('PBS.Async', { diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js index 2a1931e4..e8b003aa 100644 --- a/www/tape/ChangerStatus.js +++ b/www/tape/ChangerStatus.js @@ -469,22 +469,6 @@ Ext.define('PBS.TapeManagement.ChangerStatus', { return status; }, - renderState: function(value, md, record) { - if (!value) { - return gettext('Idle'); - } - - let icon = ''; - - if (value.startsWith("UPID")) { - let upid = Proxmox.Utils.parse_task_upid(value); - md.tdCls = "pointer"; - return `${icon} ${upid.desc}`; - } - - return `${icon} ${value}`; - }, - control: { 'grid[reference=drives]': { cellclick: function(table, td, ci, rec, tr, ri, e) { @@ -689,7 +673,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', { text: gettext('State'), dataIndex: 'state', flex: 3, - renderer: 'renderState', + renderer: PBS.Utils.renderDriveState, }, { text: gettext("Vendor"),