From 9608ac348697ae6435a639e30b7f0ea9fdc84057 Mon Sep 17 00:00:00 2001 From: Dominik Csapak Date: Tue, 6 Oct 2020 12:25:26 +0200 Subject: [PATCH] ui: Dashboard/TaskSummary: refactor types and title by moving the definition into the controller and dynamically use them in the updateTasks function we will reuse/extend this later Signed-off-by: Dominik Csapak --- www/dashboard/TaskSummary.js | 33 ++++++++++++++++++++++----------- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/www/dashboard/TaskSummary.js b/www/dashboard/TaskSummary.js index 0cf049cd..c5095751 100644 --- a/www/dashboard/TaskSummary.js +++ b/www/dashboard/TaskSummary.js @@ -7,6 +7,20 @@ Ext.define('PBS.TaskSummary', { controller: { xclass: 'Ext.app.ViewController', + types: [ + "backup", + "prune", + "garbage_collection", + "sync", + ], + + titles: { + "backup": gettext('Backups'), + "prune": gettext('Prunes'), + "garbage_collection": gettext('Garbage collections'), + "sync": gettext('Syncs'), + }, + render_icon: function(state, count) { let cls = 'question'; let color = 'faded'; @@ -40,18 +54,15 @@ Ext.define('PBS.TaskSummary', { }, }, - updateTasks: function(data) { + updateTasks: function(source) { let me = this; - data.backup.type = gettext('Backups'); - data.prune.type = gettext('Prunes'); - data.garbage_collection.type = gettext('Garbage collections'); - data.sync.type = gettext('Syncs'); - me.lookup('grid').getStore().setData([ - data.backup, - data.prune, - data.garbage_collection, - data.sync, - ]); + let controller = me.getController(); + let data = []; + controller.types.forEach((type) => { + source[type].type = controller.titles[type]; + data.push(source[type]); + }); + me.lookup('grid').getStore().setData(data); }, layout: 'fit',