tyler/proxmox-backup
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ui: remote target selectors: code cleanups

Browse Source 
just a small start...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2022-05-11 18:00:15 +02:00
parent 0e3de42aa7
commit 92b9cc1554
2 changed files with 12 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
www/form/RemoteTargetSelector.js
View File

@ -42,8 +42,7 @@ Ext.define('PBS.form.RemoteStoreSelector', {
me.remote = remote; me.remote = remote;
let store = me.store; me.store.removeAll();
store.removeAll();
if (me.remote) { if (me.remote) {
me.setDisabled(false); me.setDisabled(false);
@ -51,8 +50,8 @@ Ext.define('PBS.form.RemoteStoreSelector', {
me.clearValue(); me.clearValue();
} }
store.proxy.url = '/api2/json/config/remote/' + encodeURIComponent(me.remote) + '/scan'; me.store.proxy.url = `/api2/json/config/remote/${encodeURIComponent(me.remote)}/scan`;
store.load(); me.store.load();
me.firstLoad = false; me.firstLoad = false;
} else { } else {
@ -122,15 +121,12 @@ Ext.define('PBS.form.RemoteNamespaceSelector', {
setRemote: function(remote) { setRemote: function(remote) {
let me = this; let me = this;
if (me.remote === remote) { if (me.remote === remote) {
return; return;
} }
me.remote = remote; me.remote = remote;
let store = me.store; me.store.removeAll();
store.removeAll();
me.setDisabled(true); me.setDisabled(true);
me.clearValue(); me.clearValue();
@ -138,24 +134,23 @@ Ext.define('PBS.form.RemoteNamespaceSelector', {
setRemoteStore: function(remoteStore) { setRemoteStore: function(remoteStore) {
let me = this; let me = this;
if (me.remoteStore === remoteStore) { if (me.remoteStore === remoteStore) {
return; return;
} }
me.remoteStore = remoteStore; me.remoteStore = remoteStore;
let store = me.store; me.store.removeAll();
store.removeAll();
if (me.remote && me.remoteStore) { if (me.remote && me.remoteStore) {
me.setDisabled(false); me.setDisabled(false);
if (!me.firstLoad) { if (!me.firstLoad) {
me.clearValue(); me.clearValue();
} }
let encodedRemote = encodeURIComponent(me.remote);
let encodedStore = encodeURIComponent(me.remoteStore);
store.proxy.url = '/api2/json/config/remote/' + encodeURIComponent(me.remote) + '/scan/' + encodeURIComponent(me.remoteStore) + '/namespaces'; me.store.proxy.url = `/api2/json/config/remote/${encodedRemote}/scan/${encodedStore}/namespaces`;
store.load(); me.store.load();
me.firstLoad = false; me.firstLoad = false;
} else { } else {
@ -173,11 +168,10 @@ Ext.define('PBS.form.RemoteNamespaceSelector', {
fields: ['ns', 'comment'], fields: ['ns', 'comment'],
proxy: { proxy: {
type: 'proxmox', type: 'proxmox',
url: '/api2/json/config/remote/' + encodeURIComponent(me.remote) + '/scan', url: `/api2/json/config/remote/${encodeURIComponent(me.remote)}/scan`,
}, },
}); });
store.sort('ns', 'ASC');
store.sort('store', 'ASC');
Ext.apply(me, { Ext.apply(me, {
store: store, store: store,

2
www/window/SyncJobEdit.js
View File

@ -9,7 +9,7 @@ Ext.define('PBS.window.SyncJobEdit', {
isAdd: true, isAdd: true,
subject: gettext('SyncJob'), subject: gettext('Sync Job'),
bodyPadding: 0, bodyPadding: 0,