tyler
/
proxmox-backup
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

pbs-client: print error when we couldn't download previous fidx/didx 

When we have a previous manifest, we try to download the fidx/didx files
to get the known chunks list. We continue if that fails (which is ok),
but we did not print any error, leading to a confusing backup output,
since the users would expect that chunks will be reused.

Printing the error should at least make it apparent that something did
not work correctly.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2022-04-04 13:45:02 +02:00 committed by Dietmar Maurer
parent 2b422b82fb
commit 7c22932c64
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
pbs-client/src/backup_writer.rs
View File

@ -289,22 +289,28 @@ impl BackupWriter {
// try, but ignore errors // try, but ignore errors
match ArchiveType::from_path(archive_name) { match ArchiveType::from_path(archive_name) {
Ok(ArchiveType::FixedIndex) => { Ok(ArchiveType::FixedIndex) => {
let _ = self if let Err(err) = self
.download_previous_fixed_index( .download_previous_fixed_index(
archive_name, archive_name,
&manifest, &manifest,
known_chunks.clone(), known_chunks.clone(),
) )
.await; .await
{
eprintln!("Error downloading .fidx from previous manifest: {}", err);
}
} }
Ok(ArchiveType::DynamicIndex) => { Ok(ArchiveType::DynamicIndex) => {
let _ = self if let Err(err) = self
.download_previous_dynamic_index( .download_previous_dynamic_index(
archive_name, archive_name,
&manifest, &manifest,
known_chunks.clone(), known_chunks.clone(),
) )
.await; .await
{
eprintln!("Error downloading .didx from previous manifest: {}", err);
}
} }
_ => { /* do nothing */ } _ => { /* do nothing */ }
} }