tyler/proxmox-backup
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

verify: speedup - only verify chunks once

Browse Source 
We need to do the check before we load the chunk.
This commit is contained in:
Dietmar Maurer 2020-08-25 08:52:24 +02:00
parent 4264c5023b
commit 7ae571e7cb
1 changed files with 19 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/backup/verify.rs
View File

@ -50,7 +50,17 @@ fn verify_index_chunks(
worker.fail_on_abort()?; worker.fail_on_abort()?;
let info = index.chunk_info(pos).unwrap(); let info = index.chunk_info(pos).unwrap();
let size = info.range.end - info.range.start;
if verified_chunks.contains(&info.digest) {
continue; // already verified
}
if corrupt_chunks.contains(&info.digest) {
let digest_str = proxmox::tools::digest_to_hex(&info.digest);
worker.log(format!("chunk {} was marked as corrupt", digest_str));
errors += 1;
continue;
}
let chunk = match datastore.load_chunk(&info.digest) { let chunk = match datastore.load_chunk(&info.digest) {
Err(err) => { Err(err) => {
@ -81,20 +91,14 @@ fn verify_index_chunks(
errors += 1; errors += 1;
} }
if !verified_chunks.contains(&info.digest) { let size = info.range.end - info.range.start;
if !corrupt_chunks.contains(&info.digest) {
if let Err(err) = chunk.verify_unencrypted(size as usize, &info.digest) { if let Err(err) = chunk.verify_unencrypted(size as usize, &info.digest) {
corrupt_chunks.insert(info.digest); corrupt_chunks.insert(info.digest);
worker.log(format!("{}", err)); worker.log(format!("{}", err));
errors += 1; errors += 1;
} else { } else {
verified_chunks.insert(info.digest); verified_chunks.insert(info.digest);
}
} else {
let digest_str = proxmox::tools::digest_to_hex(&info.digest);
worker.log(format!("chunk {} was marked as corrupt", digest_str));
errors += 1;
}
} }
} }