tyler/proxmox-backup
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ui: group filter: cleanup and comment more

Browse Source 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2021-12-01 14:29:08 +01:00
parent f49cd6c135
commit 6a5a60ebfd
1 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
www/form/GroupFilter.js
View File

@ -134,28 +134,26 @@ Ext.define('PBS.form.GroupFilter', {
let regex = widget.down('textfield[type=regex]'); let regex = widget.down('textfield[type=regex]');
let group = widget.down('pbsGroupSelector'); let group = widget.down('pbsGroupSelector');
// cannot reuse the same store for all group selectors due to combo grid limitations,
// and just setting the data directly makes trouble due to Ext.util.Collection and its
// observers behavior, so, lets do a manual full-clone
let recs = []; let recs = [];
view.dsStore.each((record) => { view.dsStore.each(record => recs.push(record.data));
recs.push(record.data);
});
group.getStore().setData(recs); group.getStore().setData(recs);
// add a widget reference to the record so we can acces them // add a widget reference to the record so we can acces them from the other column
// from the other column
rec.widgets = { rec.widgets = {
type, type,
regex, regex,
group, group,
}; };
// add a record reference so we can access the record from // add a record reference so we can access the record from the change handler
// the change handler
type.record = rec; type.record = rec;
regex.record = rec; regex.record = rec;
group.record = rec; group.record = rec;
// CAUTION we just created a cyclic reference, we have to delete // CAUTION: we just created a cyclic reference, we have to delete that on filter removal!
// that on filter removal!
me.setInputValue(rec.widgets, rec); me.setInputValue(rec.widgets, rec);
}, },
@ -221,9 +219,8 @@ Ext.define('PBS.form.GroupFilter', {
if (me.isDestroyed) { if (me.isDestroyed) {
return; return;
} }
me.query('pbsGroupSelector').forEach((selector) => { let groups = records || [];
selector.getStore().setData(records || []); me.query('pbsGroupSelector').forEach(el => el.getStore().setData(groups));
});
}, },
}); });
}, },