avoid some clippy warnings

src/pxar/encoder.rs

@@ -217,7 +217,7 @@ impl<'a, W: Write, C: BackupCatalogWriter> Encoder<'a, W, C> {
         }
 
         let flags = flags::feature_flags_from_chattr(attr as u32);
-        entry.flags = entry.flags | flags;
+        entry.flags |= flags;
 
         Ok(())
     }
@@ -242,7 +242,7 @@ impl<'a, W: Write, C: BackupCatalogWriter> Encoder<'a, W, C> {
         }
 
         let flags = flags::feature_flags_from_fat_attr(attr);
-        entry.flags = entry.flags | flags;
+        entry.flags |= flags;
 
         Ok(())
     }
@@ -700,9 +700,9 @@ impl<'a, W: Write, C: BackupCatalogWriter> Encoder<'a, W, C> {
         if include_children {
             // Exclude patterns passed via the CLI are stored as '.pxarexclude-cli'
             // in the root directory of the archive.
-            if is_root && match_pattern.len() > 0 {
+            if is_root && !match_pattern.is_empty() {
                 let filename = CString::new(".pxarexclude-cli")?;
-                name_list.push((filename, dir_stat.clone(), match_pattern.clone()));
+                name_list.push((filename, *dir_stat, match_pattern.clone()));
             }
 
             for entry in dir.iter() {
@@ -1231,7 +1231,7 @@ impl<'a, W: Write, C: BackupCatalogWriter> Encoder<'a, W, C> {
 fn match_filename(
     filename: &CStr,
     stat: &FileStat,
-    match_pattern: &Vec<MatchPattern>,
+    match_pattern: &[MatchPattern],
 ) -> Result<(MatchType, Vec<MatchPattern>), Error> {
     let mut child_pattern = Vec::new();
     let mut match_state = MatchType::None;

src/pxar/flags.rs

@@ -167,7 +167,7 @@ pub fn feature_flags_from_chattr(attr: u32) -> u64 {
     let mut flags = 0u64;
 
     for (fe_flag, fs_flag) in &CHATTR_MAP {
-        if (attr & fs_flag) != 0 { flags = flags | fe_flag; }
+        if (attr & fs_flag) != 0 { flags |= fe_flag; }
     }
 
     flags
@@ -189,7 +189,7 @@ pub fn feature_flags_from_fat_attr(attr: u32) -> u64 {
     let mut flags = 0u64;
 
     for (fe_flag, fs_flag) in &FAT_ATTR_MAP {
-        if (attr & fs_flag) != 0 { flags = flags | fe_flag; }
+        if (attr & fs_flag) != 0 { flags |= fe_flag; }
     }
 
     flags

src/pxar/sequential_decoder.rs

@@ -132,11 +132,7 @@ impl<R: Read, F: Fn(&Path) -> Result<(), Error>> SequentialDecoder<R, F> {
             bail!("found invalid filename '.' or '..'.");
         }
 
-        if buffer
-            .iter()
-            .find(|b| (**b == b'/' || **b == b'\0'))
-            .is_some()
-        {
+        if buffer.iter().any(|b| (*b == b'/' || *b == b'\0')) {
             bail!("found invalid filename with slashes or nul bytes.");
         }
 
@@ -332,7 +328,7 @@ impl<R: Read, F: Fn(&Path) -> Result<(), Error>> SequentialDecoder<R, F> {
     fn restore_xattrs_fcaps_fd(
         &mut self,
         fd: RawFd,
-        xattrs: &Vec<PxarXAttr>,
+        xattrs: &[PxarXAttr],
         fcaps: &Option<PxarFCaps>,
     ) -> Result<(), Error> {
         for xattr in xattrs {
@@ -679,7 +675,7 @@ impl<R: Read, F: Fn(&Path) -> Result<(), Error>> SequentialDecoder<R, F> {
         entry: PxarEntry,
         filename: &OsStr,
         matched: MatchType,
-        match_pattern: &Vec<MatchPattern>,
+        match_pattern: &[MatchPattern],
     ) -> Result<(), Error> {
         let (mut head, attr) = self
             .read_attributes()
@@ -727,7 +723,7 @@ impl<R: Read, F: Fn(&Path) -> Result<(), Error>> SequentialDecoder<R, F> {
     /// Restore an archive into the specified directory.
     ///
     /// The directory is created if it does not exist.
-    pub fn restore(&mut self, path: &Path, match_pattern: &Vec<MatchPattern>) -> Result<(), Error> {
+    pub fn restore(&mut self, path: &Path, match_pattern: &[MatchPattern]) -> Result<(), Error> {
         let _ = std::fs::create_dir(path);
 
         let dir = nix::dir::Dir::open(
@@ -739,7 +735,7 @@ impl<R: Read, F: Fn(&Path) -> Result<(), Error>> SequentialDecoder<R, F> {
         let fd = dir.as_raw_fd();
         let mut dirs = PxarDirStack::new(fd);
         // An empty match pattern list indicates to restore the full archive.
-        let matched = if match_pattern.len() == 0 {
+        let matched = if match_pattern.is_empty() {
             MatchType::Positive
         } else {
             MatchType::None
@@ -786,7 +782,7 @@ impl<R: Read, F: Fn(&Path) -> Result<(), Error>> SequentialDecoder<R, F> {
         dirs: &mut PxarDirStack,
         filename: &OsStr,
         parent_matched: MatchType,
-        match_pattern: &Vec<MatchPattern>,
+        match_pattern: &[MatchPattern],
     ) -> Result<(), Error> {
         let relative_path = dirs.as_path_buf();
         let full_path = base_path.join(&relative_path).join(filename);
@@ -811,7 +807,7 @@ impl<R: Read, F: Fn(&Path) -> Result<(), Error>> SequentialDecoder<R, F> {
         // This is especially the case when the full archive is restored and
         // there are no match pattern.
         let mut matched = parent_matched;
-        if match_pattern.len() > 0 {
+        if !match_pattern.is_empty() {
             match match_filename(filename, ifmt == libc::S_IFDIR, match_pattern)? {
                 (MatchType::None, _) => matched = MatchType::None,
                 (MatchType::Negative, _) => matched = MatchType::Negative,
@@ -1105,7 +1101,7 @@ impl<R: Read, F: Fn(&Path) -> Result<(), Error>> SequentialDecoder<R, F> {
 fn match_filename(
     filename: &OsStr,
     is_dir: bool,
-    match_pattern: &Vec<MatchPattern>,
+    match_pattern: &[MatchPattern],
 ) -> Result<(MatchType, Vec<MatchPattern>), Error> {
     let mut child_pattern = Vec::new();
     let mut match_state = MatchType::None;
@@ -1146,7 +1142,7 @@ fn file_openat(
     mode: Mode,
 ) -> Result<std::fs::File, Error> {
     let fd =
-        filename.with_nix_path(|cstr| nix::fcntl::openat(parent, cstr.as_ref(), flags, mode))??;
+        filename.with_nix_path(|cstr| nix::fcntl::openat(parent, cstr, flags, mode))??;
 
     let file = unsafe { std::fs::File::from_raw_fd(fd) };