fix #3060:: improve get_owner error handling

log invalid owners to system log, and continue with next group just as
if permission checks fail for the following operations:
- verify store with limited permissions
- list store groups
- list store snapshots

all other call sites either handle it correctly already (sync/pull), or
operate on a single group/snapshot and can bubble up the error.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
This commit is contained in:
Fabian Grünbichler
2020-11-10 12:08:13 +01:00
committed by Dietmar Maurer
parent c5608cf86c
commit 414c23facb
2 changed files with 20 additions and 3 deletions

View File

@ -516,7 +516,12 @@ pub fn verify_all_backups(
&& !owner.is_token()
&& group_owner.user() == owner.user())
},
Err(_) => false,
Err(err) => {
// intentionally not in task log
// the task user might not be allowed to see this group!
println!("Failed to get owner of group '{}' - {}", group, err);
false
},
}
} else {
true