From 2f57a433b1f333f96e4ed6dc71b80e2575d6b453 Mon Sep 17 00:00:00 2001 From: Oguz Bektas Date: Wed, 5 Aug 2020 12:22:15 +0200 Subject: [PATCH] fix #2909: handle missing chunks gracefully in garbage collection instead of bailing and stopping the entire GC process, warn about the missing chunks and continue. this results in "TASK WARNINGS: X" as the status. Signed-off-by: Oguz Bektas --- src/backup/datastore.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backup/datastore.rs b/src/backup/datastore.rs index ffd64b81..1565712c 100644 --- a/src/backup/datastore.rs +++ b/src/backup/datastore.rs @@ -436,8 +436,8 @@ impl DataStore { tools::fail_on_shutdown()?; let digest = index.index_digest(pos).unwrap(); if let Err(err) = self.chunk_store.touch_chunk(digest) { - bail!("unable to access chunk {}, required by {:?} - {}", - proxmox::tools::digest_to_hex(digest), file_name, err); + worker.warn(&format!("warning: unable to access chunk {}, required by {:?} - {}", + proxmox::tools::digest_to_hex(digest), file_name, err)); } } Ok(())