tyler
/
proxmox-backup
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

datastore: drop bogus chunk size check, can cause trouble 

other sizes can happen in legitimate and illegitimate ways:
 - illegitimate: encryped chunks and bad actor client
 - legitimate: same chunk but newer zstd version (or compression
   level) can compress it better (or worse) so the

Ideally we could take the actual smaller chunk so that improved zstd
tech gets leveraged, but we could only allow to do that for
un-encrypted ones.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2022-05-12 15:40:55 +02:00
parent 78e1ee5230
commit 2a088b9975
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pbs-datastore/src/chunk_store.rs
View File

@ -452,10 +452,12 @@ impl ChunkStore {
} else if old_size == 0 { } else if old_size == 0 {
log::warn!("found empty chunk '{digest_str}' in store {name}, overwriting"); log::warn!("found empty chunk '{digest_str}' in store {name}, overwriting");
} else { } else {
bail!( // other sizes can happen in legitimate and illegitimate ways:
"found chunk size mismatch for '{digest_str}': old {old_size} - new \ // - illegitimate: encryped chunks and bad actor client
{encoded_size}" // - legitimate: same chunk but newer zstd version (or compression level) can
); // compress it better (or worse) so the
// Ideally we could take the actual smaller chunk so that improved zstd tech gets
// leveraged, but we could only allow to do that for un-encrypted ones.
} }
} }