tyler
/
proxmox-backup
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

downgrade some FIXMEs to TODOs 

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
This commit is contained in:
Wolfgang Bumiller 2020-06-10 11:09:23 +02:00
parent 5444fa940b
commit 26e78a2efb
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backup/catalog_shell.rs
View File

@ -23,7 +23,6 @@ use pxar::{EntryKind, Metadata};
use crate::backup::catalog::{self, DirEntryAttribute}; use crate::backup::catalog::{self, DirEntryAttribute};
// FIXME: Remove looku_self() calls by putting Directory into the dir stack
use crate::pxar::dir_stack::PxarDirStack; use crate::pxar::dir_stack::PxarDirStack;
use crate::pxar::Flags; use crate::pxar::Flags;
use crate::pxar::fuse::{Accessor, FileEntry}; use crate::pxar::fuse::{Accessor, FileEntry};
@ -289,7 +288,8 @@ async fn restore_command(target: String, pattern: Option<String>) -> Result<(),
Shell::with(move |shell| shell.restore(PathBuf::from(target), pattern)).await Shell::with(move |shell| shell.restore(PathBuf::from(target), pattern)).await
} }
/// FIXME: Should we use this to fix `step()`? /// TODO: Should we use this to fix `step()`? Make path resolution behave more like described in
/// the path_resolution(7) man page.
/// ///
/// The `Path` type's component iterator does not tell us anything about trailing slashes or /// The `Path` type's component iterator does not tell us anything about trailing slashes or
/// trailing `Component::CurDir` entries. Since we only support regular paths we'll roll our own /// trailing `Component::CurDir` entries. Since we only support regular paths we'll roll our own

2
src/pxar/fuse.rs
View File

@ -61,7 +61,7 @@ impl Session {
verbose: bool, verbose: bool,
mountpoint: &Path, mountpoint: &Path,
) -> Result<Self, Error> { ) -> Result<Self, Error> {
// FIXME: Add a buffered ReadAt layer! // TODO: Add a buffered/caching ReadAt layer?
let file = std::fs::File::open(archive_path)?; let file = std::fs::File::open(archive_path)?;
let file_size = file.metadata()?.len(); let file_size = file.metadata()?.len();
let reader: Reader = Arc::new(accessor::sync::FileReader::new(file)); let reader: Reader = Arc::new(accessor::sync::FileReader::new(file));