From 09faa9ee956f026403451e6d2c8b75a7483ca6b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= Date: Tue, 19 Jan 2021 14:46:39 +0100 Subject: [PATCH] clippy: pass &str/&[..] instead of &String/&Vec MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Fabian Grünbichler --- src/backup/prune.rs | 4 ++-- src/server/email_notifications.rs | 2 +- src/tape/online_status_map.rs | 2 +- src/tools/subscription.rs | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/backup/prune.rs b/src/backup/prune.rs index 66c2ee84..baec57d6 100644 --- a/src/backup/prune.rs +++ b/src/backup/prune.rs @@ -8,7 +8,7 @@ enum PruneMark { Keep, KeepPartial, Remove } fn mark_selections Result> ( mark: &mut HashMap, - list: &Vec, + list: &[BackupInfo], keep: usize, select_id: F, ) -> Result<(), Error> { @@ -45,7 +45,7 @@ fn mark_selections Result> ( fn remove_incomplete_snapshots( mark: &mut HashMap, - list: &Vec, + list: &[BackupInfo], ) { let mut keep_unfinished = true; diff --git a/src/server/email_notifications.rs b/src/server/email_notifications.rs index 24c15073..6af6bd38 100644 --- a/src/server/email_notifications.rs +++ b/src/server/email_notifications.rs @@ -376,7 +376,7 @@ fn get_server_url() -> (String, usize) { } pub fn send_updates_available( - updates: &Vec<&APTUpdateInfo>, + updates: &[&APTUpdateInfo], ) -> Result<(), Error> { // update mails always go to the root@pam configured email.. if let Some(email) = lookup_user_email(Userid::root_userid()) { diff --git a/src/tape/online_status_map.rs b/src/tape/online_status_map.rs index e010fbcf..52042217 100644 --- a/src/tape/online_status_map.rs +++ b/src/tape/online_status_map.rs @@ -173,7 +173,7 @@ pub fn update_changer_online_status( drive_config: &SectionConfigData, inventory: &mut Inventory, changer_name: &str, - label_text_list: &Vec, + label_text_list: &[String], ) -> Result<(), Error> { let mut online_map = OnlineStatusMap::new(drive_config)?; diff --git a/src/tools/subscription.rs b/src/tools/subscription.rs index 54819ea2..4d5caf39 100644 --- a/src/tools/subscription.rs +++ b/src/tools/subscription.rs @@ -87,8 +87,8 @@ pub struct SubscriptionInfo { } async fn register_subscription( - key: &String, - server_id: &String, + key: &str, + server_id: &str, checktime: i64 ) -> Result<(String, String), Error> { // WHCMS sample code feeds the key into this, but it's just a challenge, so keep it simple