From 633eb1d912ea81019989c9d4ee5ae27ef5dc8bd0 Mon Sep 17 00:00:00 2001
From: Nate Harris <nharris@easypost.com>
Date: Tue, 22 Feb 2022 10:47:36 -0700
Subject: [PATCH] - Fix sort option for Person template, since pulling from
 multiple options - Fix `type` and `sort_by` settings for Smart Filters (notes
 in tips_and_tricks.md)

---
 plex/pmm/collections/TV_Shows_Collections.yml    | 16 ++++++++--------
 .../collections/movies_collections_general.yml   |  9 +++++----
 plex/pmm/tips_and_tricks.md                      | 12 ++++++++++++
 3 files changed, 25 insertions(+), 12 deletions(-)

diff --git a/plex/pmm/collections/TV_Shows_Collections.yml b/plex/pmm/collections/TV_Shows_Collections.yml
index 7bab97f..f63272e 100644
--- a/plex/pmm/collections/TV_Shows_Collections.yml
+++ b/plex/pmm/collections/TV_Shows_Collections.yml
@@ -32,11 +32,11 @@ collections:
     sort_title:
     collection_level: episode
     smart_filter:
+      type: episodes
+      sort_by: release.desc
       all:
-        type: episodes
         # Episode aired in the last 8 days
         episode_air_date: 8
-        sort_by: release.desc
     sync_mode: sync
     visible_home: true
     visible_shared: true
@@ -48,11 +48,11 @@ collections:
     sort_title:
     collection_level: episode
     smart_filter:
+      type: episodes
+      sort_by: release.desc
       all:
-        type: episodes
         # Episode added in the last 7 days
         episode_added: 7
-        sort_by: release.desc
     sync_mode: sync
     visible_home: true
     visible_shared: true
@@ -62,11 +62,11 @@ collections:
     summary: "Shows now playing on Plex"
     sort_title:
     smart_filter:
+      type: shows
+      sort_by: release.desc
       all:
-        type: shows
         # Shows added in the last 30 days
         added: 30
-        sort_by: release.desc
     sync_mode: sync
     visible_library: true
     visible_home: true
@@ -101,11 +101,11 @@ collections:
     sort_title:
     collection_level: episode
     smart_filter:
+      type: episodes
+      sort_by: release.asc
       all:
-        type: episodes
         title.is: "The Simpsons"
         episode_title.contains: "Treehouse"
-        sort_by: release.asc
     sync_mode: sync
     visible_library: true
     visible_home: false
diff --git a/plex/pmm/collections/movies_collections_general.yml b/plex/pmm/collections/movies_collections_general.yml
index a6cc645..cc0de22 100644
--- a/plex/pmm/collections/movies_collections_general.yml
+++ b/plex/pmm/collections/movies_collections_general.yml
@@ -96,7 +96,7 @@ templates:
     tmdb_crew: <<person>>
     sort_title: <<level>>+09_<<collection_name>>
     sync_mode: sync
-    collection_order: custom
+    collection_order: release
     visible_library: true
 
   Actor:
@@ -142,11 +142,11 @@ collections:
                 level: "++" }
     summary: "Movies now playing on Plex"
     smart_filter:
+      type: movies
+      sort_by: release.desc
       all:
-        type: movies
         # Movie added in the last 7 days
         added: 7
-        sort_by: release.desc
     visible_home: true
     visible_shared: true
 
@@ -277,8 +277,9 @@ collections:
     template: { name: Genre }
     summary: "You might learn something"
     smart_filter:
+      type: movies
+      sort_by: critic_rating.desc
       all:
-        type: movies
         genre: Documentary
     visible_home: false
     visible_shared: false
diff --git a/plex/pmm/tips_and_tricks.md b/plex/pmm/tips_and_tricks.md
index 8036137..ce1af4d 100644
--- a/plex/pmm/tips_and_tricks.md
+++ b/plex/pmm/tips_and_tricks.md
@@ -35,9 +35,21 @@ Prefix suggestions:
   - `collection_order: release` -> `sort_by: release.desc`
   - `collection_order: alpha` -> `sort_by: title.desc`
   - `collection_order: custom` -> `sort_by: ??`
+- Needs to be one level above `all`/`any` criteria list. Ex.:
+  - `smart_filter`:
+    - sort_by: `release.desc`
+    - any:
+      - criteria1
+      - criteria2
 
 
 ## Filters
 - Type restrictions 
   - Plex `smart_filter`/`plex_search`: Use, i.e. `type: episodes`, to limit collection to [specific type](https://github.com/meisnate12/Plex-Meta-Manager/wiki/Plex-Builders#special-attributes)
+    - Needs to be one level above `all`/`any` criteria list. Ex.:
+    - `smart_filter`:
+      - type: `episodes`
+      - any:
+        - criteria1
+        - criteria2
   - All other rules: Use, i.e., `collection_level: episodes`, to limit collection to [specific type](https://github.com/meisnate12/Plex-Meta-Manager/wiki/Metadata-Details#metadata-details)